Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: increase flow control windows #2290

Open
marten-seemann opened this issue May 15, 2023 · 2 comments
Open

quic: increase flow control windows #2290

marten-seemann opened this issue May 15, 2023 · 2 comments
Labels
P1 High: Likely tackled by core team if no one steps up

Comments

@marten-seemann
Copy link
Contributor

The stream flow control window is currently limited to 10 MB. This limits transfer performance on connections with BDPs higher than that. We should use a significantly higher value than that. 50 MB seems like a better choice for well-connected servers.

This should be ok since window increases are limited by the resource manager.
@Jorropo
Copy link
Contributor

Jorropo commented May 16, 2023

Why is a limit needed in the first place ?
Couldn't you let the algorithm take as much as resource manager will allow to ?

@p-shahi p-shahi added P1 High: Likely tackled by core team if no one steps up kind/discussion Topical discussion; usually not changes to codebase labels May 22, 2023
@p-shahi p-shahi removed the kind/discussion Topical discussion; usually not changes to codebase label May 30, 2023
@p-shahi
Copy link
Member

p-shahi commented May 30, 2023

Use rcmgr's per connection memory limit to set this (inc flow control without over commitment)

@marten-seemann marten-seemann mentioned this issue May 31, 2023
Merged
@marten-seemann marten-seemann mentioned this issue Sep 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 High: Likely tackled by core team if no one steps up
Projects
go-libp2p
Status: todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marten-seemann @Jorropo @p-shahi