Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identify: expose metrics #2019

Closed
marten-seemann opened this issue Jan 27, 2023 · 0 comments · Fixed by #2126
Closed

identify: expose metrics #2019

marten-seemann opened this issue Jan 27, 2023 · 0 comments · Fixed by #2126
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@marten-seemann
Copy link
Contributor

This has already proved valuable in #1974.

For both sender and receiver side, we should track:

  • number of Identify / Identify Push messages sent
  • number of addresses in the Identify message
  • number of protocols added / removed
@marten-seemann marten-seemann added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors effort/hours Estimated to take one or several hours labels Jan 27, 2023
@marten-seemann marten-seemann mentioned this issue Jan 27, 2023
Open
16 tasks
@marten-seemann marten-seemann mentioned this issue Feb 7, 2023
Merged
@marten-seemann marten-seemann linked a pull request Feb 22, 2023 that will close this issue
identify: add metrics #2126
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

identify: add metrics sukunrt/go-libp2p
1 participant
@marten-seemann