From a83940aa6ef6eaba3570da5b449966f84804c095 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Wed, 8 Feb 2023 11:33:59 +1300 Subject: [PATCH] identify: add some basic metrics --- p2p/host/basic/basic_host.go | 2 + p2p/host/resource-manager/obs/stats.go | 3 +- p2p/metricshelper/dir.go | 14 + p2p/net/swarm/swarm_metrics.go | 19 +- .../grafana-dashboards/dashboard.json | 355 ++++++++++++++++++ p2p/protocol/identify/id.go | 23 +- p2p/protocol/identify/metrics.go | 92 +++++ p2p/protocol/identify/opts.go | 7 + 8 files changed, 498 insertions(+), 17 deletions(-) create mode 100644 p2p/metricshelper/dir.go create mode 100644 p2p/protocol/identify/grafana-dashboards/dashboard.json create mode 100644 p2p/protocol/identify/metrics.go diff --git a/p2p/host/basic/basic_host.go b/p2p/host/basic/basic_host.go index 0ea8c20baf..a269a4111d 100644 --- a/p2p/host/basic/basic_host.go +++ b/p2p/host/basic/basic_host.go @@ -230,12 +230,14 @@ func NewHost(n network.Network, opts *HostOpts) (*BasicHost, error) { identify.UserAgent(opts.UserAgent), identify.ProtocolVersion(opts.ProtocolVersion), identify.DisableSignedPeerRecord(), + identify.WithMetricsTracer(identify.NewMetricsTracer()), ) } else { h.ids, err = identify.NewIDService( h, identify.UserAgent(opts.UserAgent), identify.ProtocolVersion(opts.ProtocolVersion), + identify.WithMetricsTracer(identify.NewMetricsTracer()), ) } if err != nil { diff --git a/p2p/host/resource-manager/obs/stats.go b/p2p/host/resource-manager/obs/stats.go index 9228a8dbb2..bae3f09981 100644 --- a/p2p/host/resource-manager/obs/stats.go +++ b/p2p/host/resource-manager/obs/stats.go @@ -8,8 +8,9 @@ import ( "github.com/prometheus/client_golang/prometheus" ) +const metricNamespace = "libp2p_rcmgr" + var ( - metricNamespace = "libp2p_rcmgr" // Conns conns = prometheus.NewGaugeVec(prometheus.GaugeOpts{ diff --git a/p2p/metricshelper/dir.go b/p2p/metricshelper/dir.go new file mode 100644 index 0000000000..2f89b951c6 --- /dev/null +++ b/p2p/metricshelper/dir.go @@ -0,0 +1,14 @@ +package metricshelper + +import "github.com/libp2p/go-libp2p/core/network" + +func GetDirection(dir network.Direction) string { + switch dir { + case network.DirOutbound: + return "outbound" + case network.DirInbound: + return "inbound" + default: + return "unknown" + } +} diff --git a/p2p/net/swarm/swarm_metrics.go b/p2p/net/swarm/swarm_metrics.go index 30edd8bc0c..fb64f75369 100644 --- a/p2p/net/swarm/swarm_metrics.go +++ b/p2p/net/swarm/swarm_metrics.go @@ -94,17 +94,6 @@ func NewMetricsTracer() *metricsTracer { return &metricsTracer{} } -func getDirection(dir network.Direction) string { - switch dir { - case network.DirOutbound: - return "outbound" - case network.DirInbound: - return "inbound" - default: - return "unknown" - } -} - func appendConnectionState(tags []string, cs network.ConnectionState) []string { if cs.Transport == "" { // This shouldn't happen, unless the transport doesn't properly set the Transport field in the ConnectionState. @@ -123,12 +112,12 @@ func (m *metricsTracer) OpenedConnection(dir network.Direction, p crypto.PubKey, tags := metricshelper.GetStringSlice() defer metricshelper.PutStringSlice(tags) - *tags = append(*tags, getDirection(dir)) + *tags = append(*tags, metricshelper.GetDirection(dir)) *tags = appendConnectionState(*tags, cs) connsOpened.WithLabelValues(*tags...).Inc() *tags = (*tags)[:0] - *tags = append(*tags, getDirection(dir)) + *tags = append(*tags, metricshelper.GetDirection(dir)) *tags = append(*tags, p.Type().String()) keyTypes.WithLabelValues(*tags...).Inc() } @@ -137,12 +126,12 @@ func (m *metricsTracer) ClosedConnection(dir network.Direction, duration time.Du tags := metricshelper.GetStringSlice() defer metricshelper.PutStringSlice(tags) - *tags = append(*tags, getDirection(dir)) + *tags = append(*tags, metricshelper.GetDirection(dir)) *tags = appendConnectionState(*tags, cs) connsClosed.WithLabelValues(*tags...).Inc() *tags = (*tags)[:0] - *tags = append(*tags, getDirection(dir)) + *tags = append(*tags, metricshelper.GetDirection(dir)) *tags = appendConnectionState(*tags, cs) connDuration.WithLabelValues(*tags...).Observe(duration.Seconds()) } diff --git a/p2p/protocol/identify/grafana-dashboards/dashboard.json b/p2p/protocol/identify/grafana-dashboards/dashboard.json new file mode 100644 index 0000000000..cb828effd3 --- /dev/null +++ b/p2p/protocol/identify/grafana-dashboards/dashboard.json @@ -0,0 +1,355 @@ +{ + "__inputs": [ + { + "name": "DS_PROMETHEUS", + "label": "Prometheus", + "description": "", + "type": "datasource", + "pluginId": "prometheus", + "pluginName": "Prometheus" + } + ], + "__elements": {}, + "__requires": [ + { + "type": "grafana", + "id": "grafana", + "name": "Grafana", + "version": "9.3.6" + }, + { + "type": "datasource", + "id": "prometheus", + "name": "Prometheus", + "version": "1.0.0" + }, + { + "type": "panel", + "id": "timeseries", + "name": "Time series", + "version": "" + } + ], + "annotations": { + "list": [ + { + "builtIn": 1, + "datasource": { + "type": "grafana", + "uid": "-- Grafana --" + }, + "enable": true, + "hide": true, + "iconColor": "rgba(0, 211, 255, 1)", + "name": "Annotations & Alerts", + "target": { + "limit": 100, + "matchAny": false, + "tags": [], + "type": "dashboard" + }, + "type": "dashboard" + } + ] + }, + "editable": true, + "fiscalYearStartMonth": 0, + "graphTooltip": 0, + "id": null, + "links": [], + "liveNow": false, + "panels": [ + { + "datasource": { + "type": "prometheus", + "uid": "${DS_PROMETHEUS}" + }, + "fieldConfig": { + "defaults": { + "color": { + "mode": "palette-classic" + }, + "custom": { + "axisCenteredZero": false, + "axisColorMode": "text", + "axisLabel": "", + "axisPlacement": "auto", + "barAlignment": 0, + "drawStyle": "line", + "fillOpacity": 0, + "gradientMode": "none", + "hideFrom": { + "legend": false, + "tooltip": false, + "viz": false + }, + "lineInterpolation": "linear", + "lineWidth": 1, + "pointSize": 5, + "scaleDistribution": { + "type": "linear" + }, + "showPoints": "auto", + "spanNulls": false, + "stacking": { + "group": "A", + "mode": "none" + }, + "thresholdsStyle": { + "mode": "off" + } + }, + "mappings": [], + "thresholds": { + "mode": "absolute", + "steps": [ + { + "color": "green", + "value": null + }, + { + "color": "red", + "value": 80 + } + ] + } + }, + "overrides": [] + }, + "gridPos": { + "h": 8, + "w": 12, + "x": 0, + "y": 0 + }, + "id": 4, + "options": { + "legend": { + "calcs": [], + "displayMode": "list", + "placement": "bottom", + "showLegend": true + }, + "tooltip": { + "mode": "single", + "sort": "none" + } + }, + "targets": [ + { + "datasource": { + "type": "prometheus", + "uid": "${DS_PROMETHEUS}" + }, + "editorMode": "code", + "expr": "rate(libp2p_identify_identify_total[$__rate_interval])", + "legendFormat": "{{dir}}", + "range": true, + "refId": "A" + } + ], + "title": "Identify Messages", + "type": "timeseries" + }, + { + "datasource": { + "type": "prometheus", + "uid": "${DS_PROMETHEUS}" + }, + "fieldConfig": { + "defaults": { + "color": { + "mode": "palette-classic" + }, + "custom": { + "axisCenteredZero": false, + "axisColorMode": "text", + "axisLabel": "", + "axisPlacement": "auto", + "barAlignment": 0, + "drawStyle": "line", + "fillOpacity": 0, + "gradientMode": "none", + "hideFrom": { + "legend": false, + "tooltip": false, + "viz": false + }, + "lineInterpolation": "linear", + "lineWidth": 1, + "pointSize": 5, + "scaleDistribution": { + "type": "linear" + }, + "showPoints": "auto", + "spanNulls": false, + "stacking": { + "group": "A", + "mode": "none" + }, + "thresholdsStyle": { + "mode": "off" + } + }, + "mappings": [], + "thresholds": { + "mode": "absolute", + "steps": [ + { + "color": "green", + "value": null + }, + { + "color": "red", + "value": 80 + } + ] + } + }, + "overrides": [] + }, + "gridPos": { + "h": 8, + "w": 12, + "x": 12, + "y": 0 + }, + "id": 5, + "options": { + "legend": { + "calcs": [], + "displayMode": "list", + "placement": "bottom", + "showLegend": true + }, + "tooltip": { + "mode": "single", + "sort": "none" + } + }, + "targets": [ + { + "datasource": { + "type": "prometheus", + "uid": "${DS_PROMETHEUS}" + }, + "editorMode": "code", + "expr": "rate(libp2p_identify_identify_push_total[$__rate_interval])", + "legendFormat": "{{dir}}", + "range": true, + "refId": "A" + } + ], + "title": "Identify Push Messages", + "type": "timeseries" + }, + { + "datasource": { + "type": "prometheus", + "uid": "${DS_PROMETHEUS}" + }, + "fieldConfig": { + "defaults": { + "color": { + "mode": "palette-classic" + }, + "custom": { + "axisCenteredZero": false, + "axisColorMode": "text", + "axisLabel": "", + "axisPlacement": "auto", + "barAlignment": 0, + "drawStyle": "line", + "fillOpacity": 0, + "gradientMode": "none", + "hideFrom": { + "legend": false, + "tooltip": false, + "viz": false + }, + "lineInterpolation": "linear", + "lineWidth": 1, + "pointSize": 5, + "scaleDistribution": { + "type": "linear" + }, + "showPoints": "auto", + "spanNulls": false, + "stacking": { + "group": "A", + "mode": "none" + }, + "thresholdsStyle": { + "mode": "off" + } + }, + "mappings": [], + "thresholds": { + "mode": "absolute", + "steps": [ + { + "color": "green", + "value": null + }, + { + "color": "red", + "value": 80 + } + ] + } + }, + "overrides": [] + }, + "gridPos": { + "h": 9, + "w": 12, + "x": 0, + "y": 8 + }, + "id": 2, + "options": { + "legend": { + "calcs": [], + "displayMode": "list", + "placement": "bottom", + "showLegend": true + }, + "tooltip": { + "mode": "single", + "sort": "none" + } + }, + "targets": [ + { + "datasource": { + "type": "prometheus", + "uid": "${DS_PROMETHEUS}" + }, + "editorMode": "code", + "expr": "rate(libp2p_identify_identify_pushes_triggered_total[$__rate_interval])", + "legendFormat": "{{trigger}}", + "range": true, + "refId": "A" + } + ], + "title": "Pushes triggered", + "type": "timeseries" + } + ], + "schemaVersion": 37, + "style": "dark", + "tags": [], + "templating": { + "list": [] + }, + "time": { + "from": "now-15m", + "to": "now" + }, + "timepicker": {}, + "timezone": "", + "title": "libp2p Identify", + "uid": "0NDzQQ0Vz", + "version": 3, + "weekStart": "" +} diff --git a/p2p/protocol/identify/id.go b/p2p/protocol/identify/id.go index ff016ef792..2f5a1d8959 100644 --- a/p2p/protocol/identify/id.go +++ b/p2p/protocol/identify/id.go @@ -114,6 +114,8 @@ type idService struct { UserAgent string ProtocolVersion string + metricsTracer MetricsTracer + ctx context.Context ctxCancel context.CancelFunc // track resources that need to be shut down before we shut down @@ -176,6 +178,7 @@ func NewIDService(h host.Host, opts ...Option) (*idService, error) { conns: make(map[network.Conn]entry), disableSignedPeerRecord: cfg.disableSignedPeerRecord, pushSemaphore: make(chan struct{}, 1), + metricsTracer: cfg.metricsTracer, } observedAddrs, err := NewObservedAddrManager(h) @@ -246,7 +249,13 @@ func (ids *idService) loop(ctx context.Context) { for { select { - case <-sub.Out(): + case e, ok := <-sub.Out(): + if !ok { + return + } + if ids.metricsTracer != nil { + ids.metricsTracer.TriggeredPushes(e) + } ids.updateSnapshot() select { case triggerPush <- struct{}{}: @@ -308,6 +317,9 @@ func (ids *idService) sendPushes(ctx context.Context) { if err != nil { // connection might have been closed recently return } + if ids.metricsTracer != nil { + ids.metricsTracer.IdentifyPush(network.DirOutbound) + } // TODO: find out if the peer supports push if we didn't have any information about push support if err := ids.sendIdentifyResp(str); err != nil { log.Debugw("failed to send identify push", "peer", c.RemotePeer(), "error", err) @@ -399,15 +411,24 @@ func (ids *idService) identifyConn(c network.Conn) error { return err } + if ids.metricsTracer != nil { + ids.metricsTracer.IdentifyPush(network.DirInbound) + } return ids.handleIdentifyResponse(s, false) } // handlePush handles incoming identify push streams func (ids *idService) handlePush(s network.Stream) { ids.handleIdentifyResponse(s, true) + if ids.metricsTracer != nil { + ids.metricsTracer.IdentifyPush(network.DirInbound) + } } func (ids *idService) handleIdentifyRequest(s network.Stream) { + if ids.metricsTracer != nil { + ids.metricsTracer.Identify(network.DirOutbound) + } _ = ids.sendIdentifyResp(s) } diff --git a/p2p/protocol/identify/metrics.go b/p2p/protocol/identify/metrics.go new file mode 100644 index 0000000000..f6a40f4329 --- /dev/null +++ b/p2p/protocol/identify/metrics.go @@ -0,0 +1,92 @@ +package identify + +import ( + "sync" + + "github.com/libp2p/go-libp2p/core/event" + "github.com/libp2p/go-libp2p/core/network" + "github.com/libp2p/go-libp2p/p2p/metricshelper" + + "github.com/prometheus/client_golang/prometheus" +) + +const metricNamespace = "libp2p_identify" + +var ( + pushesTriggered = prometheus.NewCounterVec( + prometheus.CounterOpts{ + Namespace: metricNamespace, + Name: "identify_pushes_triggered_total", + Help: "Pushes Triggered", + }, + []string{"trigger"}, + ) + identify = prometheus.NewCounterVec( + prometheus.CounterOpts{ + Namespace: metricNamespace, + Name: "identify_total", + Help: "Identify", + }, + []string{"dir"}, + ) + identifyPush = prometheus.NewCounterVec( + prometheus.CounterOpts{ + Namespace: metricNamespace, + Name: "identify_push_total", + Help: "Identify Push", + }, + []string{"dir"}, + ) +) + +var initMetricsOnce sync.Once + +func initMetrics() { + prometheus.MustRegister(pushesTriggered, identify, identifyPush) +} + +type MetricsTracer interface { + TriggeredPushes(event any) + Identify(network.Direction) + IdentifyPush(network.Direction) +} + +type metricsTracer struct{} + +var _ MetricsTracer = &metricsTracer{} + +func NewMetricsTracer() MetricsTracer { + initMetricsOnce.Do(initMetrics) + return &metricsTracer{} +} + +func (t *metricsTracer) TriggeredPushes(ev any) { + tags := metricshelper.GetStringSlice() + defer metricshelper.PutStringSlice(tags) + + typ := "unknown" + switch ev.(type) { + case event.EvtLocalProtocolsUpdated: + typ = "protocols_updated" + case event.EvtLocalAddressesUpdated: + typ = "addresses_updated" + } + *tags = append(*tags, typ) + pushesTriggered.WithLabelValues(*tags...).Inc() +} + +func (t *metricsTracer) Identify(dir network.Direction) { + tags := metricshelper.GetStringSlice() + defer metricshelper.PutStringSlice(tags) + + *tags = append(*tags, metricshelper.GetDirection(dir)) + identify.WithLabelValues(*tags...).Inc() +} + +func (t *metricsTracer) IdentifyPush(dir network.Direction) { + tags := metricshelper.GetStringSlice() + defer metricshelper.PutStringSlice(tags) + + *tags = append(*tags, metricshelper.GetDirection(dir)) + identifyPush.WithLabelValues(*tags...).Inc() +} diff --git a/p2p/protocol/identify/opts.go b/p2p/protocol/identify/opts.go index 38f505b69b..f188665686 100644 --- a/p2p/protocol/identify/opts.go +++ b/p2p/protocol/identify/opts.go @@ -4,6 +4,7 @@ type config struct { protocolVersion string userAgent string disableSignedPeerRecord bool + metricsTracer MetricsTracer } // Option is an option function for identify. @@ -31,3 +32,9 @@ func DisableSignedPeerRecord() Option { cfg.disableSignedPeerRecord = true } } + +func WithMetricsTracer(tr MetricsTracer) Option { + return func(cfg *config) { + cfg.metricsTracer = tr + } +}