Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 tests leak goroutines because of go-libp2p and leveldb #906

Closed
dennis-tra opened this issue Sep 19, 2023 · 1 comment
Closed

v2 tests leak goroutines because of go-libp2p and leveldb #906

dennis-tra opened this issue Sep 19, 2023 · 1 comment
Labels
status/blocked Unable to be worked further until needs are met v2 All issues related to the v2 rewrite

Comments

@dennis-tra
Copy link
Contributor

dennis-tra commented Sep 19, 2023 •
edited
Loading

We observed that the 32-bit test runner runs out of memory if we increase the test count to 100.

There are two areas where we leak goroutines after the test has stopped:

  1. leveldb has a one-second delay before properly releasing all resources. There is nothing immediate we can do about that. If we added a delay of 1s + δ, all resources are released.
  2. go-libp2p does not clean up fx resources properly. This is a known issue and will be fixed soon: libp2p.Host leaks goroutines go-libp2p#2514

Revisit after libp2p/go-libp2p#2514 has been resolved.
@dennis-tra dennis-tra changed the title v2 tests leak goroutines because of go-libp2p issue v2 tests leak goroutines because of go-libp2p and leveldb Sep 19, 2023
@dennis-tra dennis-tra added status/blocked Unable to be worked further until needs are met v2 All issues related to the v2 rewrite labels Sep 19, 2023
@iand iand mentioned this issue Oct 2, 2023
Open
@iand
Copy link

iand commented Oct 2, 2023

Migrated to probe-lab/zikade#34

@iand iand closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/blocked Unable to be worked further until needs are met v2 All issues related to the v2 rewrite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iand @dennis-tra