Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warnings with new CMake builds #327

Closed
SFrijters opened this issue Apr 16, 2020 · 2 comments · Fixed by #329
Closed

Compiler warnings with new CMake builds #327

SFrijters opened this issue Apr 16, 2020 · 2 comments · Fixed by #329

Comments

@SFrijters
Copy link
Contributor

With the recently added warning flags in the CMake build, various compilers are complaining about things.

I'm working on a PR to fix these issues.

@noelchalmers
Copy link
Contributor

I was also looking at this. My plan was to keep the warning flags for debug builds and suppress existing warnings on release builds. There's also a bunch of changes I had to make to hook the new cmake build system into an existing cmake project and other QoL changes. I can wait on your changes first though @SFrijters

@SFrijters
Copy link
Contributor Author

My PR should be coming early next week; I have a local branch that treats the warnings for Intel and clang builds, but gcc was still complaining about some things and I will look into that on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants