Implement framework for flexible 2FA #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for using the hmac-secret FIDO extension to
contribute keying material for a KeePass 4 file.
It does this by storing an additional XML statekeeping blob in the
outer ("public") header. This blob is designed to hold a variety of
different authentication factors, such as passwords, key files, and
Yubikey challenge-response devices.
BryanJacobs
commented
Apr 16, 2024
| if "public_custom_data" in kdbx.header.value.dynamic_header: | ||
| del kdbx.header.value.dynamic_header["public_custom_data"] | ||
|
|
||
| # Beyond Python 3.7, construct makes the base class of a Container be `dict` instead of `OrderedDict` |
There was a problem hiding this comment.
This is very unfortunate: the construct library dynamically changes which methods are available on a Container based on the version the Python interpreter reports.
If you run Python 3.5, you get all the OrderedDict methods. If you run Python 3.11 you get only dict methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for using the hmac-secret FIDO extension to contribute keying material for a KeePass 4 file.
It does this by storing an additional XML statekeeping blob in the outer ("public") header. This blob is designed to hold a variety of different authentication factors, such as passwords, key files, and Yubikey challenge-response devices.
This is a reopening of the accidentally-closed #373 . Sorry about that.