Fix libssh2 inclusion in libgit2 iOS build script #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added CMAKE_PREFIX_PATH to arch-specific libssh2 root dir - Added PKG_CONFIG_USE_CMAKE_PREFIX_PATH so things actually make sense - Removed unused LIBSSH2_INCLUDE_DIRS
|
Thanks so much for tracking this down! |
joshaber
added a commit
that referenced
this pull request
Nov 10, 2015
Fix libssh2 inclusion in libgit2 iOS build script
|
Looks good over here. I notice the build log no longer mentions |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
update_libgit2_iosbuild script was mistakenly picking up libssh2 (version 1.6.0) from homebrew instead of the local version built specifically for iOS (currently 1.4.3).Resolves #531