Convert GTRepository.cloneFromURL option keys into constants

Author: isaac

Classes/GTRepository.h

@@ -94,6 +94,25 @@ typedef enum {
 	GTCheckoutNotifyAll = GIT_CHECKOUT_NOTIFY_ALL,
 } GTCheckoutNotifyFlags;
 
+// Transport flags sent as options to +cloneFromURL... method
+typedef enum {
+	GTTransportFlagsNone = GIT_TRANSPORTFLAGS_NONE,
+	// If you pass this flag and the connection is secured with SSL/TLS,
+	// the authenticity of the server certificate will not be verified.
+	GTTransportFlagsNoCheckCert = GIT_TRANSPORTFLAGS_NO_CHECK_CERT,
+} GTTransportFlags;
+
+// An `NSNumber` wrapped `GTTransportFlags`, documented above.
+// Default value is `GTTransportFlagsNone`.
+extern NSString *const GTRepositoryCloneOptionsTransportFlags;
+
+// An `NSNumber` wrapped `BOOL`, if YES, create a bare clone.
+// Default value is `NO`.
+extern NSString *const GTRepositoryCloneOptionsBare;
+
+// An `NSNumber` wrapped `BOOL`, if NO, don't checkout the remote HEAD.
+// Default value is `YES`.
+extern NSString *const GTRepositoryCloneOptionsCheckout;
 
 typedef void (^GTRepositoryStatusBlock)(NSURL *fileURL, GTRepositoryFileStatus status, BOOL *stop);
 
@@ -131,12 +150,8 @@ typedef void (^GTRepositoryStatusBlock)(NSURL *fileURL, GTRepositoryFileStatus s
 // originURL             - The URL to clone from.
 // workdirURL            - A URL to the desired working directory on the local machine.
 // withCheckout          - if NO, don't checkout the remote HEAD
-// options               - A NSDictionary with NSString keys, used for specifying clone options. Possible keys are:
-//                          - @"bare" - BOOL value, if YES, create a bare clone, for example: [NSNumber numberWithBool:YES], defaults to NO
-//                          - @"checkout" - BOOL value, if NO, don't checkout the remote HEAD, for example: [NSNumber numberWithBool:NO], defaults to YES
-//                          - @"transportFlags" - int value, two possible values:
-//                            - GIT_TRANSPORTFLAGS_NONE (0), for example: [NSNumber numberWithInt:GIT_TRANSPORTFLAGS_NONE], this is the default value
-//                            - GIT_TRANSPORTFLAGS_NO_CHECK_CERT (1), for example: [NSNumber numberWithInt:GIT_TRANSPORTFLAGS_NO_CHECK_CERT], if you pass this flag and the connection is secured with SSL/TLS, the authenticity of the server certificate will not be verified
+// options               - A dictionary containing any of the above options key constants, or
+//                         nil to use the defaults.
 // error                 - A pointer to fill in case of trouble.
 // transferProgressBlock - This block is called with network transfer updates.
 // checkoutProgressBlock - This block is called with checkout updates (if withCheckout is YES).

Classes/GTRepository.m

@@ -44,6 +44,9 @@
 #import "NSString+Git.h"
 #import "GTDiffFile.h"
 
+NSString *const GTRepositoryCloneOptionsBare = @"GTRepositoryCloneOptionsBare";
+NSString *const GTRepositoryCloneOptionsCheckout = @"GTRepositoryCloneOptionsCheckout";
+NSString *const GTRepositoryCloneOptionsTransportFlags = @"GTRepositoryCloneOptionsTransportFlags";
 
 // The type of block passed to -enumerateSubmodulesRecursively:usingBlock:.
 typedef void (^GTRepositorySubmoduleEnumerationBlock)(GTSubmodule *submodule, BOOL *stop);
@@ -172,13 +175,13 @@ + (id)cloneFromURL:(NSURL *)originURL toWorkingDirectory:(NSURL *)workdirURL opt
 
 	git_clone_options cloneOptions = GIT_CLONE_OPTIONS_INIT;
 
-	NSNumber *bare = options[@"bare"];
+	NSNumber *bare = options[GTRepositoryCloneOptionsBare];
 	cloneOptions.bare = bare == nil ? 0 : bare.boolValue;
 
-	NSNumber *transportFlags = options[@"transportFlags"];
+	NSNumber *transportFlags = options[GTRepositoryCloneOptionsTransportFlags];
 	cloneOptions.transport_flags = transportFlags == nil ? 0 : transportFlags.intValue;
 
-	NSNumber *checkout = options[@"checkout"];
+	NSNumber *checkout = options[GTRepositoryCloneOptionsCheckout];
 	BOOL withCheckout = checkout == nil ? YES : checkout.boolValue;
 
 	if (withCheckout) {