-
Notifications
You must be signed in to change notification settings - Fork 899
Create/Delete to Add/Remove #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dahlbyk could you please consider to rebase nulltoken@300bddc34a54231d1fcb7c6d92f2697258b523eb as part of your PR? |
👍 |
BTW, creating a PR on top of "CreateToAdd~2" -> Pure awesomeness :) |
I had started with this but it felt weird having the new implement the old. No more weird than having hidden inherited members though, so I've squashed your change into dahlbyk/libgit2sharp@d422a63.
It seemed like a good idea at the time, but the new push to the branch wasn't detected. Probably too much of an edge case for GH to implement. I was able to force the refresh through the API (since I own the PR), but instead of keeping |
Did you ever push it? |
ok found it: dahlbyk/libgit2sharp@293f26e074bc |
And merged! :) Could you create a new PR with the two remaining commits? We'll merge it as soon as v0.10.0 is released. |
Per discussion in #164:
CommitCollection.Create()
➡️Repository.Commit()
Create()
➡️Add()
Delete()
➡️Remove()
Configuration
maybeDelete()
➡️Unset()
?My branch also includes commits to remove obsolete methods/interfaces after the next version ships.