Skip to content

Create/Delete to Add/Remove #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Conversation

dahlbyk
Copy link
Member

@dahlbyk dahlbyk commented Jun 9, 2012

Per discussion in #164:

  • CommitCollection.Create() ➡️ Repository.Commit()
  • Create() ➡️ Add()
  • Delete() ➡️ Remove()
    • Not included, but for Configuration maybe Delete() ➡️ Unset()?

My branch also includes commits to remove obsolete methods/interfaces after the next version ships.

@nulltoken
Copy link
Member

@dahlbyk could you please consider to rebase nulltoken@300bddc34a54231d1fcb7c6d92f2697258b523eb as part of your PR?

@nulltoken
Copy link
Member

Not included, but for Configuration maybe Delete() ➡️ Unset()?

👍

@nulltoken
Copy link
Member

BTW, creating a PR on top of "CreateToAdd~2" -> Pure awesomeness :)

@dahlbyk
Copy link
Member Author

dahlbyk commented Jun 9, 2012

could you please consider to rebase nulltoken@300bddc as part of your PR?

I had started with this but it felt weird having the new implement the old. No more weird than having hidden inherited members though, so I've squashed your change into dahlbyk/libgit2sharp@d422a63.

Not included, but for Configuration maybe Delete() ➡️ Unset()?

dahlbyk/libgit2sharp@283f26e

BTW, creating a PR on top of "CreateToAdd~2" -> Pure awesomeness :)

It seemed like a good idea at the time, but the new push to the branch wasn't detected. Probably too much of an edge case for GH to implement.

I was able to force the refresh through the API (since I own the PR), but instead of keeping CreateToAdd~2 I switched to the branch in case there are future iterations.

@nulltoken
Copy link
Member

Not included, but for Configuration maybe Delete() ➡️ Unset()?

dahlbyk/libgit2sharp@283f26e

Did you ever push it?

@nulltoken
Copy link
Member

ok found it: dahlbyk/libgit2sharp@293f26e074bc

@nulltoken
Copy link
Member

And merged! :)

Could you create a new PR with the two remaining commits? We'll merge it as soon as v0.10.0 is released.

@nulltoken nulltoken closed this Jun 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants