XML Warnings #174
Closed
XML Warnings #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TreeEntryChanges inherited from ContentChanges, but they're really not the same thing.
Um.... no.
@dahlbyk I'm the one who "committed" the Thanks a lot for the refactoring. It was indeed very needed. Fixing the warning was an unexpected 🎁 Manually merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a particular reason XML docs were turned off for Debug? Happened to switch over to Release and thought I'd clean up what I found.
@yorah, can you look at the
ContentChangesrefactoring? Tests pass, of course, but I want to make sure my inference of the relationship betweenContentChangesandTreeEntryChangesis correct.