Skip to content

Latest commit

 

History

History
29 lines (22 loc) · 1.07 KB

de-controller.rst

File metadata and controls

29 lines (22 loc) · 1.07 KB

Notes on the device event controller machinery

In pyatspi2, Registry.setReferenceWIndow() is misspelled. However, that function is never called in Orca or elsewhere, as far as I can tell.

This ties down to atspi_registry_set_reference_window(), which just calls _atspi_mutter_set_reference_window(). The side effect of that is to set the ATSPI_MUTTER_DATA.window_id and window_id_is_explicit, but again, those fields never get used in the atspi-mutter.c code. I think they were meant to be used in _atspi_mutter_generate_keyboard_event or _atspi_mutter_generate_mouse_event.

Relatedly, _atspi_mutter_generate_keyboard_event takes a keystring argument but it’s not used.

What is incomplete here?

Refactoring plan

While the device event controller (DEC) code works for X11, it doesn’t work for Wayland because there are no hooks there to sniff the keyboard or mouse.

However, the machinery to synthesize events is presumably still useful. I’d like to be able to add tests for it.