Skip to content

web_agency_hero #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: web_agency_hero
Choose a base branch
from
Open

Conversation

4Solome
Copy link

@4Solome 4Solome commented Mar 16, 2024

My Ayiko , how is this?

Copy link
Owner

@lgmfred lgmfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kazam_screenshot_00000

It's close but not close enough.

  1. You're not using the Open Sans font in the original design
  2. The text "Dave's Devs & Designers" is supposed to take two lines
  3. The underline is too thin
  4. Make the text in the button bolder

Copy link
Owner

@lgmfred lgmfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the amazon_product_page file from this branch and you're good. Don't forget to make the underline on the "come true." text thicker.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be part of the web_agency_hero branch as it is for the Amazon product page challenge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants