Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LF icon #94

Open
petervdonovan opened this issue Feb 4, 2023 · 5 comments
Open

Add LF icon #94

petervdonovan opened this issue Feb 4, 2023 · 5 comments

Comments

@petervdonovan
Copy link
Contributor

Recently VS Code was updated to allow extensions to contribute icons when the main icon theme (which is most commonly seti) does not provide them. We should take advantage of this feature.

@lhstrh
Copy link
Member

lhstrh commented May 6, 2023

Is this an icon for files or for something else? We already have an icon checked in here; what is that one used for?

@petervdonovan
Copy link
Contributor Author

Files. That icon which we already have checked in appears when you look up our extension on the marketplace.

It is very easy to add our own file icon. The hard part is creating the icon.

@lhstrh
Copy link
Member

lhstrh commented May 6, 2023

Is there a spec for the icon format? Size and extension?

@petervdonovan
Copy link
Contributor Author

Some information is provided here.

@petervdonovan
Copy link
Contributor Author

When I tried using a PNG like what is currently in the images folder of this repo, I found that it did not look very good because the image was just a little bit too large/detailed. In order to close this issue we might need a slightly smaller icon. This is not something we should prioritize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants