Build should fail if there are multiple lsp jars

[cmnrd]

When I run npm install on the current master, then the resulting lib directory is empty. Consequently, the generated *.vsix is broken and the extension cannot start the language server. I also noticed that the resulting extension is called vscode-lingua-franca-0.5.1.vsix despite the recent 0.6.0 release.

[cmnrd]

Now I noticed the error message in npm's output:

Error: Multiple matches to /home/cmenard/projects/lf/vscode-lingua-franca/lingua-franca/lsp/build/libs/lsp-+(?).+(?).+(?)?(-SNAPSHOT)-all.jar were found. Please delete the jars that you do not want to use.
    at copyJar (/home/cmenard/projects/lf/vscode-lingua-franca/src/build_lds.ts:48:15)
    at build (/home/cmenard/projects/lf/vscode-lingua-franca/src/build_lds.ts:130:9)

I deleted the jars and now it works fine.

Would be great if npm actually fails if there is an error.

[cmnrd]

The created artifact is still called vscode-lingua-franca-0.5.1.vsix

[lhstrh]

Just tried to reproduce, but it works just fine on my end. Did you pull the latest and updated submodules recursively?

[cmnrd]

Ok, looks like something went wrong when I pulled. I had not checked out the latest main before... Sorry for the noise!

So this issue breaks down to npm not failing in case there are multiple lsp jars. While it prints

Error: Multiple matches to /home/cmenard/projects/lf/vscode-lingua-franca/lingua-franca/lsp/build/libs/lsp-+(?).+(?).+(?)?(-SNAPSHOT)-all.jar were found. Please delete the jars that you do not want to use.
    at copyJar (/home/cmenard/projects/lf/vscode-lingua-franca/src/build_lds.ts:48:15)
    at build (/home/cmenard/projects/lf/vscode-lingua-franca/src/build_lds.ts:130:9)

This is easily missed as the overall build succeeds.