Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize access to sparse multiports #36

Open
oowekyala opened this issue Nov 17, 2022 · 0 comments
Open

Optimize access to sparse multiports #36

oowekyala opened this issue Nov 17, 2022 · 0 comments
Labels
enhancement New feature or request optimization Related to performance optimizations

Comments

@oowekyala
Copy link
Collaborator

The C++ runtime supports sparse multiports more efficiently since lf-lang/reactor-cpp#24. The set ports can be queried more efficiently because they're saved in a vector in the multiport. This apparently has significant performance impact on benchmarks like Big.

The Rust runtime cannot support this directly yet -setting a port does not notify any of the downstream ports, and ports do not know the multiports that contain them anyway. I imagine this will be difficult to implement because of the constraints on circular references in Rust. Maybe a solution would be to introduce new data structures to track which port can influence which multiport, which would be prepared during initialization.

@oowekyala oowekyala added enhancement New feature or request optimization Related to performance optimizations labels Nov 17, 2022
@oowekyala oowekyala changed the title Optimise access to sparse multiports Optimize access to sparse multiports Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Related to performance optimizations
Projects
None yet
Development

No branches or pull requests

1 participant