Rename "version" directory to avoid Zephyr macOS issue #480
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petervdonovan, the reason I asked for your review Peter is that you know how this version library is being used in proprietary plugins. Will moving the location of this folder break any such plugins? |
erlingrj
force-pushed
the
dont-use-version
branch
from
8d8f994
to
2b70a6d
Compare
|
You are right that that was my initial intention. However, I don't think it is being used for that purpose yet, and I am not aware of current plans to use it for that purpose. |
petervdonovan
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Zephyr build system looks for a file named
VERSIONin the root of a project. Since macOS, for some reason, has a default case-insensitive file system, theversiondirectory in reactor-c gets interpreted as theVERSIONfile and it breaks the build.To resolve this conflict I moved the
versionfolder to~/core/version. I think this is acceptable.