Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braces not allowed for reactors without parameters #1855

Open
lhstrh opened this issue Jun 19, 2023 · 0 comments
Open

Braces not allowed for reactors without parameters #1855

lhstrh opened this issue Jun 19, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@lhstrh
Copy link
Member

lhstrh commented Jun 19, 2023

Our grammar does not allow:

reactor() {
  ...
}

but there is no clear reason for this restriction (and the resulting error message is not particularly clear).
We can allow empty braces this by writing (('(' parameters+=Parameter (',' parameters+=Parameter)* ')') | '(' ')')?
instead of ('(' parameters+=Parameter (',' parameters+=Parameter)* ')')?.

@lhstrh lhstrh changed the title Braces now allowed for reactors without parameters Braces not allowed for reactors without parameters Jun 19, 2023
@lhstrh lhstrh added the good first issue Good for newcomers label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant