Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last round of half and game will store win_type and winner incorrectly #30

Open
Barsnes opened this issue Aug 22, 2020 · 3 comments
Open

Comments

@Barsnes
Copy link

Barsnes commented Aug 22, 2020

A typical round would be stored in the API wtih all the information needed, however for the last round of the half, and last round of the game, the winner and win_type are stored as nulls. This is consistent throughout all demos I've tested with

correct:

           "round": 1
            "players": {
              "76561198130490651": {
                "kills": 1,
                "killshs": 1,
                "damage": 77
              }, { ... }
            },
            "winner": "T",
            "win_type": "elimination"
          },

incorrect:

           "round": 15
            "players": {
              "76561198130490651": {
                "kills": 1,
                "killshs": 1,
                "damage": 77
              }, { ... }
            },
            "winner": null,
            "win_type": null
          },
@Barsnes Barsnes changed the title Round 15 and winning round store win_type and winner incorrectly Last round of half and game will store win_type and winner incorrectly Aug 22, 2020
@osztenkurden
Copy link
Contributor

It seems like its the way demos are saved - some config system (ex ESEA) makes demos not sending the same data as on live matches, therefore making demos unusable. I will look into it though

@Barsnes
Copy link
Author

Barsnes commented Sep 16, 2020

It seems like its the way demos are saved - some config system (ex ESEA) makes demos not sending the same data as on live matches, therefore making demos unusable. I will look into it though

I've done some testing and it seems like it's because of the way eBot sends data and ends round 15 and the last round

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants