Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable attach() to work with any buffer when given context data. #683

Merged
merged 2 commits into from
Feb 3, 2023
Merged

feat: Enable attach() to work with any buffer when given context data. #683

merged 2 commits into from
Feb 3, 2023

Conversation

sindrets
Copy link
Contributor

@sindrets sindrets commented Dec 5, 2022

Resolves #682.

@lewis6991
Copy link
Owner

Looks really clean and tidy on first look 👍. Will take a deeper look when I can (need to be extra careful about API changes).

Only comment right now would be to factor the context creation into a function (if it makes sense to).

@sindrets sindrets force-pushed the feat/general-attach branch 2 times, most recently from 141f842 to 0618601 Compare December 6, 2022 12:29
@sindrets sindrets mentioned this pull request Dec 7, 2022
Draft
@lewis6991 lewis6991 merged commit ec4742a into lewis6991:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewis6991 lewis6991 Awaiting requested review from lewis6991

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable attach() to work with any buffer given the necessary context data
2 participants
@sindrets @lewis6991