refactor: make override_csv_permissions available in csv_permissions

- making this available in csv_permissions makes it accessible to apps that want to temporarily override the CSV permissions with a string

Author: Levi Cameron

csv_permissions/test_utils.py

@@ -0,0 +1,27 @@
+import contextlib
+import tempfile
+from typing import Iterable
+
+from django.test import override_settings
+
+
+@contextlib.contextmanager
+def override_csv_permissions(csv_datas: Iterable[str]):
+    """
+    Creates temporary CSV files with the specified contents and then sets the
+    """
+
+    if isinstance(csv_datas, str):
+        raise TypeError("csv_datas should be an iterable of file contents; did you forget to wrap it in [ ]?")
+
+    csv_filepaths = []
+
+    with contextlib.ExitStack() as stack:
+        for csv_data in csv_datas:
+            f = stack.enter_context(tempfile.NamedTemporaryFile("w"))
+            csv_filepaths.append(f.name)
+            f.writelines(csv_data.strip())
+            f.seek(0)
+
+        with override_settings(CSV_PERMISSIONS_PATHS=csv_filepaths):
+            yield

test_csv_permissions/test_evaluators.py

@@ -7,10 +7,10 @@
 import csv_permissions.evaluators
 import csv_permissions.legacy
 import csv_permissions.permissions
+from csv_permissions.test_utils import override_csv_permissions
 
 from .models import TestModelA
 from .models import TestModelD
-from .test_utils import override_csv_permissions
 from .test_utils import USER1_TYPE
 from .test_utils import User1Factory
 from .test_utils import USER2_TYPE

test_csv_permissions/test_legacy.py

@@ -7,11 +7,11 @@
 import csv_permissions
 import csv_permissions.legacy
 import csv_permissions.permissions
+from csv_permissions.test_utils import override_csv_permissions
 import test_csv_permissions.rules
 
 from .models import TestModelA
 from .models import TestModelE
-from .test_utils import override_csv_permissions
 from .test_utils import USER1_TYPE
 from .test_utils import User1Factory
 from .test_utils import USER2_TYPE

test_csv_permissions/test_parse.py

@@ -7,9 +7,9 @@
 
 import csv_permissions.evaluators
 import csv_permissions.permissions
+from csv_permissions.test_utils import override_csv_permissions
 
 from .models import TestModelA
-from .test_utils import override_csv_permissions
 from .test_utils import USER1_TYPE
 from .test_utils import User1Factory
 from .test_utils import USER2_TYPE

test_csv_permissions/test_utils.py

@@ -1,10 +1,6 @@
-import contextlib
-import tempfile
 from typing import Dict
-from typing import Iterable
 import warnings
 
-from django.test import override_settings
 from django.test.utils import TestContextDecorator
 
 from test_csv_permissions.factory import UserFactory
@@ -22,25 +18,6 @@ def User2Factory(**kwargs):
     return UserFactory.create(user_type=USER2_TYPE, **kwargs)
 
 
-@contextlib.contextmanager
-def override_csv_permissions(csv_datas: Iterable[str]):
-    """
-    Creates temporary CSV files with the specified contents and then sets the
-    """
-
-    csv_filepaths = []
-
-    with contextlib.ExitStack() as stack:
-        for csv_data in csv_datas:
-            f = stack.enter_context(tempfile.NamedTemporaryFile("w"))
-            csv_filepaths.append(f.name)
-            f.writelines(csv_data)
-            f.seek(0)
-
-        with override_settings(CSV_PERMISSIONS_PATHS=csv_filepaths):
-            yield
-
-
 class warning_filter(TestContextDecorator):
     """
     Apply a warning.simplefilter()