Merge pull request #41 from level12/fix-azure-path-handling

Escape blob name before putting in final URL

Author: Nick Zaccardi

keg_storage/backends/azure.py

@@ -321,7 +321,8 @@ def _create_sas_url(self, path: str, sas_permissions: str,
             expiry=expire,
             ip=ip
         )
-        url = urllib.parse.urljoin(self.account_url, '{}/{}'.format(self.bucket, path))
+        escaped_path = urllib.parse.quote(path, safe="")
+        url = urllib.parse.urljoin(self.account_url, '{}/{}'.format(self.bucket, escaped_path))
         return '{}?{}'.format(url, token)
 
     def create_container_url(self, expire: typing.Union[arrow.Arrow, datetime],

keg_storage/tests/test_backend_azure.py

@@ -267,7 +267,7 @@ def test_upload_url(self, expire: Union[arrow.Arrow, datetime.datetime]):
         )
         parsed = urlparse.urlparse(url)
         assert parsed.netloc == 'foo.blob.core.windows.net'
-        assert parsed.path == '/test/abc/def.txt'
+        assert parsed.path == '/test/abc%2Fdef.txt'
         qs = urlparse.parse_qs(parsed.query)
 
         assert qs['se'] == ['2019-01-02T03:04:05Z']
@@ -283,7 +283,7 @@ def test_upload_url(self, expire: Union[arrow.Arrow, datetime.datetime]):
         )
         parsed = urlparse.urlparse(url)
         assert parsed.netloc == 'foo.blob.core.windows.net'
-        assert parsed.path == '/test/abc/def.txt'
+        assert parsed.path == '/test/abc%2Fdef.txt'
         qs = urlparse.parse_qs(parsed.query)
 
         assert qs['se'] == ['2019-01-02T03:04:05Z']
@@ -303,7 +303,7 @@ def test_download_url(self, expire: Union[arrow.Arrow, datetime.datetime]):
         )
         parsed = urlparse.urlparse(url)
         assert parsed.netloc == 'foo.blob.core.windows.net'
-        assert parsed.path == '/test/abc/def.txt'
+        assert parsed.path == '/test/abc%2Fdef.txt'
         qs = urlparse.parse_qs(parsed.query)
 
         assert qs['se'] == ['2019-01-02T03:04:05Z']
@@ -320,7 +320,7 @@ def test_download_url(self, expire: Union[arrow.Arrow, datetime.datetime]):
         )
         parsed = urlparse.urlparse(url)
         assert parsed.netloc == 'foo.blob.core.windows.net'
-        assert parsed.path == '/test/abc/def.txt'
+        assert parsed.path == '/test/abc%2Fdef.txt'
         qs = urlparse.parse_qs(parsed.query)
 
         assert qs['se'] == ['2019-01-02T03:04:05Z']