Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run eggsampler/acme integration tests during CI #289

Open
cpu opened this issue Nov 19, 2019 · 0 comments
Open

Run eggsampler/acme integration tests during CI #289

cpu opened this issue Nov 19, 2019 · 0 comments

Comments

@cpu
Copy link
Contributor

cpu commented Nov 19, 2019

Pebble originated as a piece of test code and one of the unfortunate side effects of that is that it doesn't have significant integration test coverage (and no unit tests 😱).

The https://github.com/eggsampler/acme project has nice integration tests that run against Pebble out-of-box with the unmodified docker-compose.yml that's in the Pebble repo: https://github.com/eggsampler/acme/blob/4ddd811df83288943ed699958499c4e7a32143ed/Makefile#L11-L38

Running these tests during the Pebble CI will help catch bugs sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant