Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create OID package #6986

Open
pgporada opened this issue Jul 11, 2023 · 2 comments
Open

Create OID package #6986

pgporada opened this issue Jul 11, 2023 · 2 comments
Labels
starter Ideal issues for folks getting familiar with Boulder

Comments

@pgporada
Copy link
Member

There are many OIDs spinkled throughout boulder such as the following snippet. We should build a package that defines OIDs by class similar to how pyca/cryptography handles them.

//ca/crl.go: asn1.ObjectIdentifier{2, 5, 29, 28}
//cmd/ceremony/cert.go: var oidOCSPNoCheck = asn1.ObjectIdentifier{1, 3, 6, 1, 5, 5, 7, 48, 1, 5}
//wfe2/wfe.go: asn1.ObjectIdentifier{2, 16, 840, 1, 101, 3, 4, 2, 1}
etc
@aarongable aarongable added this to the Sprint 2023-08-01 milestone Aug 1, 2023
@pgporada pgporada removed their assignment Sep 26, 2023
@mcpherrinm
Copy link
Contributor

We may be able to use the new x509.OID type instead of making a new one: golang/go#60665

@aarongable
Copy link
Contributor

I think we should use both the new x509.OID and the existing asn1.ObjectIdentifier types in our package, since the OIDs we care about fall into both categories (policy identifiers and extension identifiers, respectively).

@aarongable aarongable assigned pgporada and unassigned pgporada Nov 28, 2023
@aarongable aarongable added the starter Ideal issues for folks getting familiar with Boulder label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
starter Ideal issues for folks getting familiar with Boulder
Projects
None yet
Development

No branches or pull requests

3 participants