New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Implement trig approximation functions to reduce size #4865

Open

TD-er opened this issue Nov 2, 2023 · 0 comments

Labels

Type: Enhancement

Member

TD-er commented Nov 2, 2023

For the "minimal OTA" builds, we might save quite some space when using the trig functions as used in Tasmota.
See: https://github.com/arendst/Tasmota/blob/development/tasmota/tasmota_support/support_float.ino

The current implementation often uses a double variant internally which is slow and requires quite a bit of code.

Found some benchmarks online comparing int/float/double operations showing the float operations are significantly faster (20 - 40x) compared to the double implementations:
https://www.reddit.com/r/esp32/comments/t46960/whats_the_esp32_s3_floating_point_performance/

TD-er added the Type: Enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment