Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Client IP filtering using CIDR notation #4791

Open
iz8mbw opened this issue Sep 6, 2023 · 3 comments
Open

[FR] Client IP filtering using CIDR notation #4791

iz8mbw opened this issue Sep 6, 2023 · 3 comments
Labels
Category: Frontend Related to web-interface Type: Feature Request Add a completely new feature (e.g. controller/plugin)

Comments

@iz8mbw
Copy link
Contributor

iz8mbw commented Sep 6, 2023

Hello.
Currently the "Client IP filtering" under "Main Settings" page accepts only "Allow all", ""Allow Local Subnet" and "Allow IP range" and so it's not possible to specify different subnets.
For example it is not possible to allows "192.168.1.0/24" and "10.10.0.0/24" in the same time. And, as you can understand, create a so big range doesn't make sense.

As Future Request can be the final solution to use the CIDR notation for Client IP filtering (providing a list of CIDR to allow).

Thanks.

@TD-er
Copy link
Member

TD-er commented Sep 6, 2023

Hmm that's a bit tricky as adding an arbitrary number of ranges does require significant changes in the settings structure.
So it may sound like a simple request, but it really isn't.

@TD-er TD-er added Type: Feature Request Add a completely new feature (e.g. controller/plugin) Category: Frontend Related to web-interface labels Sep 6, 2023
@iz8mbw
Copy link
Contributor Author

iz8mbw commented Sep 7, 2023

OK.
So, as "workaround", can be implemented to allow multiple IP ranges?
Example:
From 192.168.1.0 To 192.168.1.254 AND From 10.10.0.0 To 10.10.0.254 ?

@TD-er
Copy link
Member

TD-er commented Sep 7, 2023

Right now the settings struct for this only has 4 bytes for the lower range and 4 bytes for the upper range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Frontend Related to web-interface Type: Feature Request Add a completely new feature (e.g. controller/plugin)
Projects
None yet
Development

No branches or pull requests

2 participants