Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the heels of
IntoReactiveValuewe can now change thewhenprop ofShowto anInto<Signal<bool>>>.Existing code should continue working without change but it is technically a breaking change.
But this unifies the API between
<Show>,<AnimatedShow>and<ShowLet>.Please note that I also tried to use the
Into<Signal<Option<T>>>>approach for<ShowLet>but this creates an additional indirection for type inference which the compiler often can't do automatically. So I kept the custom approach from before which in effect yields the same result.In addtion to that I wanted to update the examples to simplify the
Showusage where applicable. That lead me to port the projectsso_auth_axumto the latest Leptos version (was pre 0.6). I did not port other projects but it seems some of them would require it.