fix(controls): ui:Button foreground error on pressed#1723
Open
emako wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Wpf.Ui.Controls.Button control template so the text/icon foreground is correctly applied during Pressed and Disabled states (addressing #1722), restoring the expected foreground after interaction.
Changes:
- Update the pressed-state trigger to set
TextElement.Foregroundon the template’sContentPresenterandControlIconinstead of setting the button’sForeground. - Update the disabled-state trigger similarly to ensure both content and icon reflect the disabled foreground brush.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
#1722
Issue Number: 1722
What is the new behavior?
Other information