feat(controls): Add GridSplitter support to LeftNavigationViewTemplate#1603
Draft
Koichi-Kobayashi wants to merge 4 commits intolepoco:mainfrom
Draft
feat(controls): Add GridSplitter support to LeftNavigationViewTemplate#1603Koichi-Kobayashi wants to merge 4 commits intolepoco:mainfrom
Koichi-Kobayashi wants to merge 4 commits intolepoco:mainfrom
Conversation
- Add IsGridSplitterEnabled dependency property to enable/disable GridSplitter - Implement GridSplitter between navigation pane and content area - Ensure navigation pane width resizes with GridSplitter while maintaining left alignment - Manage PaneColumn width through code-behind using OpenPaneLength as initial width - Remove ColumnDefinition width animations from VisualStateManager to prevent exceptions - Add proper event handler cleanup and thread-safe updates using Dispatcher - Handle GridLength safely with IsAbsolute checks before accessing Value property - Default value is false to maintain backward compatibility
github-actions
bot
added
controls
- Add UpdatePaneColumnWidthForToggle method to handle pane open/close events - Call UpdatePaneColumnWidthForToggle from OnPaneOpened and OnPaneClosed - Ensure PaneColumn width updates correctly when toggle button is clicked - Preserve manually resized width when toggling pane open/closed - Fix issue where pane width was not updating when using GridSplitter
Collaborator
|
This destroys the navigation animations and makes the search box collapse extremely ugly. |
Contributor
Author
|
Sorry about that.
2026-01-12_22h25_59.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
The width of the navigation panel can be specified using OpenPaneLength,
but it cannot be resized dynamically.
I came up with a better approach than my pull request #1519.
What is the new behavior?
The GridSplitter allows users to manually resize the navigation pane width,
and the navigation menu automatically adjusts its width accordingly while
staying left-aligned. The initial width is controlled by the OpenPaneLength property.
Other information
2025-12-14_01h06_52.mp4