feat(controls): Add an “Add Button” and a “Close Button” to the tab control. Additionally, drag-and-drop functionality has been enabled.#1587
Open
Koichi-Kobayashi wants to merge 26 commits intolepoco:mainfrom
Conversation
github-actions
bot
added
themes
- Implement TabAddingProperty and TabClosingProperty attached properties in TabControlExtensions to allow XAML-based event handler assignment - Add comprehensive XML documentation comments for the new properties and their change handlers - Add implementation examples in Gallery with detailed code samples - Enable XAML syntax: uiControls:TabControlExtensions.TabAdding="Handler" and uiControls:TabControlExtensions.TabClosing="Handler"
Koichi-Kobayashi
changed the title
* fix(controls): CardExpander has inconsistent CornerRadius * Add System.Windows.Data using directive
* chore: Fix readme header * chore: Update sitemap
…ting tabs Add TargetNullValue to SymbolIcon Symbol binding in scroll bar button styles to handle null Content values during tab deletion. - ScrollBar.xaml: Add TargetNullValue to UiScrollBarLineButton - DynamicScrollBar.xaml: Add TargetNullValue to DynamicScrollBarLineButton
github-actions
bot
added
documentation
Contributor
Author
|
There was an issue where the close button was displayed even when tabs were set not to be closable. |
- Update TabControlExtensions to control close button visibility based on IsClosable property only - Fix tab spacing when close button is hidden by using fixed column width instead of Auto - Add example in TabControlPage to make first tab non-closable - Update method documentation comments in TabControlPage
Contributor
Author
|
We have adjusted the display state and spacing of the close button on the tab control. Please review. |
Collaborator
So, to align this with WinUI 3 where possible, I'm wondering if we should split the control in two:
It has close buttons, drag & drop, etc. Its description says "provides the user with a collection of tabs that can be used to display several documents".
…and WinUI 2(?) called it a Pivot: 
My thinking is that low-level, we can do these changes, but high-level, using TabControl directly through WPF-UI should be discouraged; rather, we provide two high-level controls
…that internally use TabControl, but externally expose the appropriate properties. Or maybe we can have a property |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
Issue Number: #557 #770 #1402
What is the new behavior?
-Added an “Add Button” and a “Close Button”
-Enabled tab dragging and dropping
Other information
2025-11-29_11h33_36_TabContorl.mp4