From dc8a7d53cb39a0353ac27ae79bf44b7208f743c9 Mon Sep 17 00:00:00 2001 From: tiger Date: Tue, 23 Apr 2024 23:24:55 +0200 Subject: [PATCH] fix editor in new page context --- .../forms/fields/studioeditor/studioeditor.html.twig | 9 +++++---- assets/res/eventMgr.js | 3 ++- assets/res/extensions/findReplace.js | 3 +-- assets/res/layout.js | 11 ++--------- 4 files changed, 10 insertions(+), 16 deletions(-) diff --git a/admin/templates/forms/fields/studioeditor/studioeditor.html.twig b/admin/templates/forms/fields/studioeditor/studioeditor.html.twig index bf2371cd8..e55d8e85d 100644 --- a/admin/templates/forms/fields/studioeditor/studioeditor.html.twig +++ b/admin/templates/forms/fields/studioeditor/studioeditor.html.twig @@ -2,7 +2,8 @@ {% set codemirrorOptions = {'spellcheck': 'true', 'mode': 'gfm', 'ignore': ['code', 'preview']}|merge(field.codemirror|default({})) %} {% endif %} -{% set value = (value is null ? field.default : value) %} +{% set value = (value is null ? (field.default is null ? "" : field.default) : value) %} + {% block label %} {% if field.label %} {% set hint = field.help ? 'data-hint="' ~ field.help|tu|raw ~ '"': '' %} @@ -12,8 +13,8 @@ {% block field %} {% if field.name == 'content' %} - -
+ +
@@ -85,7 +86,7 @@ name="{{ (scope ~ field.name)|fieldName }}" id="wmd-input-store" {% if field.classes is defined %}class="{{ field.classes }} hide" {% endif %} - {% if not field.classes is defined %}class="{{ field.classes }} hide" {% endif %} + {% if not field.classes is defined %}class="hide" {% endif %} {% if field.style is defined %}style="{{ field.style|e }}" {% endif %} {% if field.disabled or isDisabledToggleable %}disabled="disabled"{% endif %} {% if field.placeholder %}placeholder="{{ field.placeholder|tu }}"{% endif %} diff --git a/assets/res/eventMgr.js b/assets/res/eventMgr.js index e18830de3..20b67b67a 100644 --- a/assets/res/eventMgr.js +++ b/assets/res/eventMgr.js @@ -73,6 +73,7 @@ define([ eventListenerListMap[eventName] = getExtensionListenerList(eventName); return function() { logger.log(eventName, arguments); + var eventArguments = arguments; _.each(eventListenerListMap[eventName], function(listener) { // Use try/catch in case userCustom listener contains error @@ -80,7 +81,7 @@ define([ listener.apply(null, eventArguments); } catch(e) { - console.error(_.isObject(e) ? e.stack : e); + console.error(_.isObject(e) ? e.stack : e); } }); }; diff --git a/assets/res/extensions/findReplace.js b/assets/res/extensions/findReplace.js index a7fa62452..35f53929b 100644 --- a/assets/res/extensions/findReplace.js +++ b/assets/res/extensions/findReplace.js @@ -258,7 +258,6 @@ define([ show(); e.preventDefault(); }); - }; - + }; return findReplace; }); diff --git a/assets/res/layout.js b/assets/res/layout.js index be571d068..ed195c47b 100644 --- a/assets/res/layout.js +++ b/assets/res/layout.js @@ -271,17 +271,11 @@ define([ } function resizeAll() { - /* - windowSize = { - width: window.innerWidth, - height: window.innerHeight - }; - */ var wmdPanelWidth = $('#wmd-panel').innerWidth(); - var editorHeight = window.innerHeight - $('.studio-media-field').innerHeight() - 60; + var editorHeight = window.innerHeight - ($('.studio-media-field').length ? $('.studio-media-field').innerHeight() : 0) - 60; if (!$('.studio-markdown-editor').hasClass('studio-editor-fullscreen')) { - editorHeight = ($('.content-wrapper').innerHeight() / 2) - $('.studio-media-field').innerHeight() - 60; + editorHeight = ($('.content-wrapper').innerHeight() / 2) - ($('.studio-media-field').length ? $('.studio-media-field').innerHeight() : 0) - 60; if (editorHeight < 480) { editorHeight = 480; } @@ -290,7 +284,6 @@ define([ width: wmdPanelWidth, height: editorHeight }; - while (true) { // Layout wrapper level 1 wrapperL1.y = navbar.isOpen ? 0 : -navbarHeight;