Skip to content

Made the missing features for v2 to be released. #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: v2
Choose a base branch
from
Open

Made the missing features for v2 to be released. #152

wants to merge 7 commits into from

Conversation

HerrChaos
Copy link

Bro please just update the plugin. You guys made such cool things and I just finished the rest. Please update.

Herr Chaos and others added 3 commits February 27, 2025 08:27
- Made LaTeX be a valid format as input.
3d357e0 
- Made Points be plottable
- Fix Graph Type Selector
- Removed some console logs.
fixed up unwanted changes of the last commit
05a6ce7
@HerrChaos
- Add decimal separator option
9da3cef 
- Add tip renderer option
- Add Derivatives
- Add editing screen. (partially)
@github-actions github-actions bot added the code label Mar 2, 2025
@leonhma
Copy link
Owner

leonhma commented Mar 7, 2025

Hey! This looks promising. I'll get to reviewing and testing this right away

leonhma
leonhma requested changes Mar 7, 2025
View reviewed changes
Copy link
Owner

@leonhma leonhma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I noted some changes that should be made. Also i noticed the Edit Plot functionality gives me an error when pressing Done. Could you fix this?

After this, there are still some minor bugs to be ironed out before a v2, but i will take care of those.

@HerrChaos HerrChaos requested a review from leonhma March 10, 2025 07:53
@HerrChaos
- Improved function name regex rule
59a4c9b 
- made the datums function name be the regexed result
- Some code clean up
@SuperJappie08
Copy link

I needed Log plotting, so I forked and modified a few things.

During this, I found some bugs.
The main one (not introduced by me changing V2 parsing to YAML and making most things optional) is that derivatives cannot use constants (it is a simple fix; I needed to pass constants to the scope of the derivative as well).
However, the scope field in the code block is currently not being used.

Link to my patches: SuperJappie08/obsidian-functionplot

@SuperJappie08
Copy link

I also found that legends collide with titles if the name is sufficiently long enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonhma leonhma Awaiting requested review from leonhma

Assignees

No one assigned

Labels

code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HerrChaos @leonhma @SuperJappie08