-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker build loconotion failed. #137
Comments
Looks like this happens because the crome download link is broken (404): Maybe it's possible to bump the "chrome version" variable. |
As I understand this is the file where the no longer valid chrome version is set: Line 17 in eb86257
|
Maybe we can use this alternative link? @Trost123 |
Btw @Trost123 , do u know how to fix it? |
I'd probably fork this repo and fix the chrome url or version. But I don't know how to use the forked version in:
And I don't have time right now to figure it out. |
I encountered the same issue and spent some time troubleshooting it. Here is the modified Dockerfile which works for me, #138. Before the author approves my PR, my workaround is to point to my repo, This is my code snippet,
from https://github.com/choux130/myblog-yintingchou-notion/blob/main/.github/workflows/pages_deploy.yml Hope this help! |
Thanks a lot for the contribution @choux130, although this seems to still fail: Bumping it to the latest version "116.0.5845.187-1" seemed to work, but this doesn't look right. I'm not sure why the previous version is not available anymore |
Work in my repo. `name: Publish Notion website to GitHub Pages on: Manual update only.workflow_dispatch: permissions: jobs:
|
hey @InakiRaba91 , I updated my
|
Thanks @choux130, that does the trick! However, I think freezing the version would be more robust. Otherwise, newer Chrome releases might break the workflow. I'll try and figure out why the frozen version was not available anymore after a new release came up. |
hello @InakiRaba91, I agree with you that freezing the version is a better practice that is why my original version of Dockerfile was to hardcode the versions of chrome and chromedrive. If you figure out how we can still get the old version when the new version is out. Please let me know, I would like to change my code to use the fixed version. Thank you! |
Hi @leoncvlt
I setup my yml like this
However, I got this error from
run: docker-compose build loconotion
. Do u know how to fix it?The text was updated successfully, but these errors were encountered: