-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker container not building #117
Comments
This is an easy one :) @philfreo Check out the docker file and uncomment the lines that download this dependency. |
Update: my pull request to fix this issue wasn't fixed because the Docker build is not a priority for the Author (see: #133) But I found a work around by auto-installing the chrome driver such that there is no need for docker in the first place in my fork of loconotion here: https://github.com/sueszli/notionSnapshot/ |
Hi, I'm a beginner 😁 Can you tell me the name of the file where I need to uncomment? |
@vlafriday it's been a while since i last touched this project and I can't remember which line it was anymore. but as mentioned: in my fork you don't even need docker to build anything |
@sueszli maybe you have a video tutorial or an article for https://github.com/sueszli/notionSnapshot/ ? I'm just learning and I'm having difficulties 😢 Thank you very much |
@vlafriday well - sadly i don't :/ |
@sueszli Do I need to add the "snapshots" folder to a project on github? I'm having some problems deploying on vercel |
I got a number of dependency issues likely due to the outdated chromedriver version. I was able to replace the custom install and use a maintained chromedriver base image though. The updated dockerfile looks like
|
@awhiteside1 a docker script is a total overkill for this project as there are chrome auto-installers in python. |
Any ideas?
CC @sueszli since I see you're also trying to get things working in Docker
The text was updated successfully, but these errors were encountered: