Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on embedding
hpm
inhyper
.hpm
obviously uses your wonderful lib.And I have a problem with it. Because I'm using webpack to pack
hpm
in a single standalone file. And in this casepkginfo
is not compatible. Requiring it directly throw an exception:I found some explanations here: meteor/meteor#6313 (comment)
Offending lines in
pkginfo
are: https://github.com/indexzero/node-pkginfo/blob/f4e90ac77034ee9eb3dd7aafc56657d7376795a8/lib/pkginfo.js#L129-L133This previous PR: #97 add some robustness against
pkg
but this is not enough with webpack.This PR make it work if getting version is disabled.
I'm not sure if a webpack option could fix it but this PR do not change
args
features