Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👽 deprecate all lower-case HTTP method annotations #651

Merged

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Feb 3, 2025

This pull request includes changes to the chopper library to standardize HTTP method annotations by replacing the old annotations with new uppercase versions and marking the old ones as deprecated. Additionally, it updates the test service to use the new annotations.

Standardization of HTTP method annotations:

Updates to test service:


Fixes #632 based on #632 (comment)

@techouse techouse added the enhancement New feature or request label Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (a59df12) to head (3fa27c0).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #651   +/-   ##
========================================
  Coverage    93.38%   93.38%           
========================================
  Files           21       21           
  Lines          499      499           
========================================
  Hits           466      466           
  Misses          33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@techouse
Copy link
Collaborator Author

techouse commented Feb 3, 2025

Copy link
Contributor

@Guldem Guldem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I kinda dislike the whole deprecation but this is also more inline with usual writing of http methods. That's also a plus I guess 😉

@JEuler
Copy link
Collaborator

JEuler commented Feb 5, 2025

So cool! Thank you!

@JEuler
Copy link
Collaborator

JEuler commented Feb 5, 2025

We can remove them somewhere in future.

@techouse techouse merged commit fc60863 into develop Feb 5, 2025
6 checks passed
@techouse techouse deleted the chore/deprecate-old-annotations-to-avoid-collisions branch February 5, 2025 21:34
@techouse techouse added this to the 8.1.0 milestone Feb 6, 2025
@techouse techouse changed the title 👽 deprecate all lower-case method annotations 👽 deprecate all lower-case HTTP method annotations Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong generated code with classes of the same name
3 participants