-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create "@2x" high-res icon assets for Mac builds #31
Comments
Also, according to the docs, we can tell raco to set the incs rather than having us moving them inside the .app ourselves: |
@IonoclastBrigham I do like the idea of using ImageMagick (or possibly GraphicsMagick) to take care of exporting the SVG at different sizes. Adding a build requirement will be less of an issue when we add binary packages, right? |
1.0 was just released as binary packages for windows, linux, and os x. So yeah, the build dependency is irrelevant for the average user. And anyone who can install racket and build ivy from source likely already has ImageMagick installed. This is probably okay. To your point, Mac and iOS apps can bundle copies of their raster assets with @2x and @3x variants for higher-density screens. This is equivalent to the drawable-Xdpi directory structure, for Android apps. It's not strictly necessary, as the system will try to pick the best version available, and scale it if needed. But it could potentially look kinda janky, so if you want control over how it looks, you provide them. Alternatively, we might be able to use a vector version directly, though it might need to be exported from svg to some intermediate format. I know a lot of iOS/OS X graphics get packaged up as PDFs, but I'm not sure you can do that kinda thing with app icons. |
Update: |
This is just a bit of visual polish for Mac users with high-density screens. I think we can just copy or link to the corresponding next-size-up asset in the implicit "@1x" icon set for all but the largest one. We'd just need to add the final image which we can generate at build time from the .SVG original.
Concerns and possible risks:
icon_256x256@2x.png
will work, or if the system will respect the embedded screen density setting. Need to look this up in the docsconvert -size 512x512 img/ivy-logo.svg mac.iconset/icon_256x256@2x.png
, possibly adding arguments to set the embedded density tag; OS X doesn't ship with ImageMagick though, so users would need to get it from MacPorts, Homebrew, source tarball, etc.The text was updated successfully, but these errors were encountered: