Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace redisearch python package with redis >= 4.0.0 #39

Closed
nathanweeks opened this issue Jan 8, 2022 · 15 comments
Closed

Replace redisearch python package with redis >= 4.0.0 #39

nathanweeks opened this issue Jan 8, 2022 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@nathanweeks
Copy link
Contributor

Per the RediSearch/redisearch-py repo, the redisearch python package has been deprecated as of redis-py 4.0.0, as its functionality was absorbed into the latter. Will need to get on the bandwagon at some point and make the switch in this repo.

@alancleary
Copy link
Collaborator

Thanks for creating an issue, Nathan. I hadn't noticed the deprecation notice.

Looking at the redis-py source, it looks like they basically copy-pasted the redisearch library in as a module, so migrating shouldn't be too difficult, in theory. Unfortunately, it looks like there still isn't support for aio, so my little aio shim layer will have to remain. Maybe I'll create an issue in the redis-py repo for this...

@alancleary
Copy link
Collaborator

Apparently redis-py is also absorbing aioredis (one library to rule them all!). This will be official in the imminent 4.2.0 release, so I'll hold off on tackling this issue until 4.2.0 is out. In the meantime I'll open an issue on redis-py about whether or not the absorbed redisearch module will work with the aioredis client once its assimilation is complete.

@alancleary
Copy link
Collaborator

Release 4.2.0 is out! I'll get going on this as soon as I can.

I opened an issue regarding aio support within the RediSearch module and the initial response suggested that it may be a while before they have integration. Oh well. Our aio wrapper works just fine so this issue can move ahead with that.

@alancleary
Copy link
Collaborator

The redisearch-py authors confirmed in the issue I previously mentioned that support for aio was added to the redis-yp redisearch module in release 4.3.1, meaning this work can now include removing our custom aio wrapper for redisearch.

@alancleary alancleary self-assigned this Jul 13, 2022
@alancleary alancleary added the enhancement New feature or request label Jul 13, 2022
@alancleary
Copy link
Collaborator

alancleary commented Jul 13, 2022

Commit c62a957 updated the chromosome service to use the redis package in place of the aioredis and redisearch packages.

Edit: Whoops. It was the genes service I updated, not the chromosome service. I pushed a new commit that overwrites the previous commit to correct the erroneous message: 7367958

@alancleary
Copy link
Collaborator

Updated the chromosome service in commit 7f097e7.

@alancleary
Copy link
Collaborator

Updated the micro-synteny search service in commit 3060d3d.

@alancleary
Copy link
Collaborator

Updated the pairwise macro-synteny blocks service in commit bd81a24.

@alancleary
Copy link
Collaborator

alancleary commented Jul 14, 2022

Updated the macro-synteny service in commit f8680ad. Note: this uncovered a bug in the redisearch module of the redis package, which I've opened an issue for: redis/redis-py#2279

@alancleary
Copy link
Collaborator

Updated the gene search service in commit 1a30d38.

@alancleary
Copy link
Collaborator

Updated the chromosome region service in commit 026cb2f.

@alancleary
Copy link
Collaborator

Updated the chromosome search service in commit 3fcb0de.

@alancleary
Copy link
Collaborator

I removed the aioredis dependency from the search service in commit 68067a8. I did not replace it with the redis package because the service isn't actually using redis!

@alancleary
Copy link
Collaborator

Updated the redis_loader in commit 12e1c12.

@alancleary
Copy link
Collaborator

All Python packages have been updated to redis 4+. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants