Skip to content

Commit c387af1

Browse files
authored
Merge pull request KnpLabs#481 from acrobat/class-rename
Renamed deploykeys class to reflect to github api name
2 parents e40df2e + 706ba5d commit c387af1

File tree

7 files changed

+8
-8
lines changed

7 files changed

+8
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ $github = new Github\Client($httpClient);
2929
$github = new Github\Client(new Github\HttpClient\Builder($httpClient));
3030
$github = Github\Client::createWithHttpClient($httpClient);
3131
```
32-
32+
- Renamed the currentuser `DeployKeys` api class to `PublicKeys` to reflect to github api name.
3333

3434
## 2.0.0-rc4
3535

doc/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ APIs:
55
* [Authorizations](authorizations.md)
66
* [Commits](commits.md)
77
* Current User
8-
* [Deploy keys / Public keys](currentuser/deploykeys.md)
8+
* [Public keys](currentuser/publickeys.md)
99
* [Memberships](currentuser/memberships.md)
1010
* [Enterprise](enterprise.md)
1111
* [Gists](gists.md)
File renamed without changes.

lib/Github/Api/CurrentUser.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace Github\Api;
44

5-
use Github\Api\CurrentUser\DeployKeys;
5+
use Github\Api\CurrentUser\PublicKeys;
66
use Github\Api\CurrentUser\Emails;
77
use Github\Api\CurrentUser\Followers;
88
use Github\Api\CurrentUser\Memberships;
@@ -64,11 +64,11 @@ public function issues(array $params = array(), $includeOrgIssues = true)
6464
}
6565

6666
/**
67-
* @return DeployKeys
67+
* @return PublicKeys
6868
*/
6969
public function keys()
7070
{
71-
return new DeployKeys($this->client);
71+
return new PublicKeys($this->client);
7272
}
7373

7474
/**

lib/Github/Api/CurrentUser/DeployKeys.php renamed to lib/Github/Api/CurrentUser/PublicKeys.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
* @link http://developer.github.com/v3/users/keys/
1010
* @author Joseph Bielawski <stloyd@gmail.com>
1111
*/
12-
class DeployKeys extends AbstractApi
12+
class PublicKeys extends AbstractApi
1313
{
1414
/**
1515
* List deploy keys for the authenticated user.

test/Github/Tests/Api/CurrentUser/DeployKeysTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,6 @@ public function shouldRemoveKey()
104104
*/
105105
protected function getApiClass()
106106
{
107-
return \Github\Api\CurrentUser\DeployKeys::class;
107+
return \Github\Api\CurrentUser\PublicKeys::class;
108108
}
109109
}

test/Github/Tests/Api/CurrentUserTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public function shouldGetDeployKeysApiObject()
9191
{
9292
$api = $this->getApiMock();
9393

94-
$this->assertInstanceOf(\Github\Api\CurrentUser\DeployKeys::class, $api->keys());
94+
$this->assertInstanceOf(\Github\Api\CurrentUser\PublicKeys::class, $api->keys());
9595
}
9696

9797
/**

0 commit comments

Comments
 (0)