Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement Opinion] Move onIndexChanged from UNSAFE_componentWillUpdate to componentDidUpdate #1144

Open
ovistoica opened this issue Jan 27, 2020 · 0 comments
Open

[Improvement Opinion] Move onIndexChanged from UNSAFE_componentWillUpdate to componentDidUpdate #1144

ovistoica opened this issue Jan 27, 2020 · 0 comments

Comments

@ovistoica
Copy link

Which OS ?

Mac Mojave

Version

Which versions are you using:

  • react-native-swiper 1.6.0-rc.3
  • react-native v0.61.2

Improvement Proposal

This is not an issue per say, but I am wondering, wouldn't it be safer for further react & react native releases to move onIndexChanged from UNSAFE_componentWillUpdate to componentDidUpdate? At the moment, onIndexChanged is the only function used there and most likely, this is going to cause crashes on the next react release
@ovistoica ovistoica changed the title [Improvement Opinion] Move onIndexChanged from UNSAFE_componentWillUpdate to componentDidUpdate [Improvement Opinion] Move onIndexChanged from UNSAFE_componentWillUpdate to componentDidUpdate Jan 27, 2020
@anujsachan1990 anujsachan1990 mentioned this issue Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ovistoica