Merge #1
Merged
Merge #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Plan: - Run on ipad - test out onIsPictureInPictureSupported, onIsPictureInPictureActive, restoreUserInterfaceForPictureInPictureStop, startPictureInPicture, stopPictureInPicture
…r to align with player state
… true. requestAudioFocus was being run regardless of there being a src, so I made it so that only gets requested when a src exists.
Support for displaying controls in Android Exoplayer
Feature Implementation: Recovery from transient internet failures
If an undefined source is accidentally loaded in react-native-video a fatal error SIGABRT will happen and crash the application. This is very difficult to debug since there's apparently no relation between this crash and react-native-video. So this change checks if the URI is empty and, if it is, it throws an error, allowing the user to find out early about the issue. https://cloud.githubusercontent.com/assets/5795227/20283860/08223ba6-aabb-11e6-9fdc-d12d32b3aa9a.png
* fix(ios): message sent to deallocated instance * chore: update changelog
…IManager.getViewManagerConfig('RCTVideo')` (and ensuring backwards compat) (#1487)
* replaced UIManager.RCTVideo > UIManager.getViewManagerConfig('RCTVideo')
* added requested changes
* updated changelog.md
* docs: adjust wording
Throw an error instead of crashing app when video source is empty
Instead of crashing, show a warning and return
Implement picture in picture for iOS
iOS KVO Crash Fix
Android 28, pre to androidx
Fix memory leak on iOS when using `controls` (AVPlayerViewController)
…s-audio Bugfix/android disablefocus audio
[iOS] fix when controls & muted
…-on-expplayer # Conflicts: # CHANGELOG.md
…ons-on-expplayer handle racing conditions when props are setted on exoplayer
keshav-raj
pushed a commit
to keshav-raj/react-native-video
that referenced
this pull request
Aug 30, 2022
Fix AudioFocus bug that could cause the player to stop responding to play/pause in some instances. Fixes issue react-native-video#1945 This was caused by the player requesting audio focus on each play (un-pause) and that resulted in a small window of Audio focus loss and then gain. The focus loss results in the player being paused while the player was supposed to play at the time. The solution is to keep track of Audio focus and not request new focus if we already have it.
keshav-raj
pushed a commit
to keshav-raj/react-native-video
that referenced
this pull request
Aug 30, 2022
Fix for tvOS native audio menu language selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:
Update the documentation
If you've added new functionality, update the README.md with an entry for your prop or event.
The entry should be inserted in alphabetical order.
Update the changelog
After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.
Provide an example of how to test the change
If the PR requires special testing setup provide all the relevant instructions and files. This may include a sample video file or URL, configuration, or setup steps.
Focus the PR on only one area
Testing multiple features takes longer than isolated changes and if there is a bug in one feature, prevents the other parts of your PR from getting merged until it gets fixed.
If you're touching multiple different areas that aren't related, break the changes up into multiple PRs.
Describe the changes
Add a note describing what your PR does. If there is a change to the behavior of the code, explain why it needs to be updated.