Add REST API code from the chill-dashboard #1

badyakarprabin · 2017-06-17T17:17:34Z

Extract the REST API express server code from chill-dashboard to this repository.

Note: Some of the files here (eg: config.js, logger.js etc) are complete copy-paste from those from the chill repository, we'll need to extract these common codes, utils, and initialization/config stuff to a new package called chill-core to avoid code duplication.

kabirbaidhya · 2017-06-17T17:20:58Z

.eslintrc

@@ -0,0 +1,30 @@
+{


copy the .eslintrc.yml file from the chill repo instead. https://github.com/leapfrogtechnology/chill/blob/master/.eslintrc.yml

badyakarprabin · 2017-06-17T17:21:02Z

Copied code from chill repo and pasted in chill rest api repo .

kabirbaidhya · 2017-06-17T17:22:11Z

.nodemonignore

+test
+
+# Other directories
+src/server/seeds


src/server?

kabirbaidhya · 2017-06-17T17:22:32Z

.postcssrc.js

@@ -0,0 +1,8 @@
+// https://github.com/michael-ciniawsky/postcss-load-config


This was a frontend specific file. Not needed here

kabirbaidhya · 2017-06-17T17:23:32Z

.travis.yml

@@ -0,0 +1,10 @@
+language: node_js


Which editor are you using? It's putting unnecessary characters at the end.

kabirbaidhya · 2017-06-17T17:23:39Z

package.json

+  },
+  "keywords": [
+    "chill",
+    "dashboard"


kabirbaidhya · 2017-06-17T17:24:03Z

package.json

+    "babel-preset-es2015": "^6.18.0",
+    "babel-preset-es2016": "^6.16.0",
+    "babel-preset-es2017": "^6.16.0",
+    "babel-preset-react": "^6.23.0",


remove this

kabirbaidhya · 2017-06-17T17:24:12Z

package.json

+    "babel-loader": "^6.2.10",
+    "babel-plugin-istanbul": "^4.1.1",
+    "babel-plugin-transform-es2015-modules-commonjs": "^6.24.0",
+    "babel-plugin-transform-react-remove-prop-types": "^0.3.3",


kabirbaidhya · 2017-06-17T17:24:44Z

package.json

+    "mocha": "^3.2.0",
+    "node-sass": "^4.5.0",
+    "nodemon": "^1.11.0",
+    "postcss-loader": "^1.3.3",


kabirbaidhya · 2017-06-17T17:24:48Z

package.json

+    "nodemon": "^1.11.0",
+    "postcss-loader": "^1.3.3",
+    "rimraf": "^2.5.4",
+    "sass-loader": "^6.0.2",


kabirbaidhya · 2017-06-17T17:25:00Z

package.json

+    "sinon": "^2.1.0",
+    "sinon-chai": "^2.8.0",
+    "supertest": "^2.0.1",
+    "url-loader": "^0.5.8"


kabirbaidhya · 2017-06-17T17:27:04Z

src/services/status.js

+ * @return {Promise}
+ */
+export async function getStatus(id) {
+  return await new Status({ id }).fetch()


let status = await new Status({ id }).fetch(); if (!status) { throw new Boom.notFound('Service not found'); } return status;

kabirbaidhya · 2017-06-17T17:28:15Z

src/utils/logger.js

+    })
+  ]
+});
+


@badyakarprabin I think you've made some changes in this log format in the chill right? Copy that from here https://github.com/leapfrogtechnology/chill.

kabirbaidhya · 2017-06-18T09:22:30Z

.babelrc

+    "es2015", "es2016", "es2017"
+  ],
+  "comments": false,
+  "env": {


No need this block

kabirbaidhya · 2017-06-18T09:23:24Z

.eslintrc

@@ -0,0 +1,30 @@
+{


Delete this file. We already have .eslintrc.yml file now.

kabirbaidhya · 2017-06-19T16:49:43Z

I'll finalize this PR.

Rest of the people will review this

mesaugat · 2017-06-20T05:33:54Z

The question is how many repositories will me make?

kabirbaidhya · 2017-06-20T06:17:41Z

Nice question 😄.

mesaugat · 2017-06-20T08:03:11Z

And why do we need those configuration files here?

kabirbaidhya · 2017-06-20T09:36:11Z

They aren't actually separate config files, both the rest api and monitor needs to access the same chill.yml file. That's the issue.
Even if we have config.yml for just monitor and .env file for the rest-api (as was before) we're going to have some config keys duplicated in both of the places and utils like logger are common for both. That's why we'll need to make the chill.yml file a centralized config file.

Also, as we're thinking of moving the persistence logic from chill to the rest-api, it needs to access the services array of the chill.yml too.

badyakarprabin added 2 commits June 16, 2017 23:19

Add rest api code from chill dashboard

aae3626

Chill-Rest update package.json file

918b586

kabirbaidhya reviewed Jun 17, 2017

View reviewed changes

.nodemonignore Outdated

test

# Other directories

src/server/seeds

Copy link

Contributor

kabirbaidhya Jun 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/server?

kabirbaidhya previously requested changes Jun 17, 2017

View reviewed changes

Chill RA Fix PR comments

136f74f

kabirbaidhya requested review from deepsadhi, mesaugat, pratishshr and romitamgai June 17, 2017 17:36

kabirbaidhya changed the title ~~Dev Rest API codes~~ Add REST API code from the chill-dashboard Jun 17, 2017

badyakarprabin added 5 commits June 18, 2017 00:45

Chill-RA Fix PR comments.

30ebfca

Chill RA Fix PR bugs

cb91f1c

Chill API Add required packages

5f2ee0e

Chill API logger

a34156c

Chill Api Add eslint package

5418779

kabirbaidhya reviewed Jun 19, 2017

View reviewed changes

kabirbaidhya added 4 commits June 19, 2017 22:00

Remove unnecessary code

7e40b43

Add additional npm scripts & dependencies

39079e0

Use same config file format as the chill monitor

e506c05

Knex configuration and migrations

f5fce52

kabirbaidhya added the wip label Jun 19, 2017

kabirbaidhya added 4 commits June 19, 2017 22:59

Refactor code

305262a

Initialize the config before express app

8342c13

Use winston logger for morgan too

a2accd1

Update README

e3022b7

kabirbaidhya removed the wip label Jun 19, 2017

mesaugat approved these changes Jun 20, 2017

View reviewed changes

romitamgai merged commit af008a6 into master Jun 23, 2017

mesaugat deleted the dev branch June 23, 2017 10:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add REST API code from the chill-dashboard #1

Add REST API code from the chill-dashboard #1

badyakarprabin commented Jun 17, 2017 •

edited by kabirbaidhya

Loading

kabirbaidhya Jun 17, 2017

badyakarprabin commented Jun 17, 2017

kabirbaidhya Jun 17, 2017

kabirbaidhya Jun 17, 2017

kabirbaidhya Jun 17, 2017

badyakarprabin Jun 17, 2017

kabirbaidhya Jun 17, 2017

kabirbaidhya Jun 17, 2017

kabirbaidhya Jun 17, 2017

kabirbaidhya Jun 17, 2017

kabirbaidhya Jun 17, 2017

kabirbaidhya Jun 17, 2017

kabirbaidhya Jun 17, 2017

kabirbaidhya Jun 17, 2017

kabirbaidhya Jun 18, 2017

kabirbaidhya Jun 18, 2017

kabirbaidhya commented Jun 19, 2017

mesaugat commented Jun 20, 2017

kabirbaidhya commented Jun 20, 2017

mesaugat commented Jun 20, 2017

kabirbaidhya commented Jun 20, 2017 •

edited

Loading

		@@ -0,0 +1,8 @@
		// https://github.com/michael-ciniawsky/postcss-load-config

Add REST API code from the chill-dashboard #1

Add REST API code from the chill-dashboard #1

Conversation

badyakarprabin commented Jun 17, 2017 • edited by kabirbaidhya Loading

Choose a reason for hiding this comment

badyakarprabin commented Jun 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kabirbaidhya commented Jun 19, 2017

mesaugat commented Jun 20, 2017

kabirbaidhya commented Jun 20, 2017

mesaugat commented Jun 20, 2017

kabirbaidhya commented Jun 20, 2017 • edited Loading

badyakarprabin commented Jun 17, 2017 •

edited by kabirbaidhya

Loading

kabirbaidhya commented Jun 20, 2017 •

edited

Loading