fix: on-close event handler not be triggered on flutter >= 3.10 #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related issue comes: flutter/engine#40033
Kingtous
changed the title
|
LGTM |
Merrit
added a commit
to Merrit/nyrna
that referenced
this pull request
Jul 5, 2023
A fix was merged that makes it work on Linux. See: leanflutter/window_manager#343
Merrit
added a commit
to Merrit/nyrna
that referenced
this pull request
Jul 5, 2023
A fix was merged that makes it work on Linux. See: leanflutter/window_manager#343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a workaround to remove the
delete-eventhandlers in the flutter engine on Linux, which breaks the propagation ofon-closeevent.Note that it only happens on flutter >= 3.10, and the problem is brought by flutter/engine#40033 (comment).
Future: this pr may break some latest api provided by Flutter, but currently we must fix the
setPreventCloseto ensure the validity of this important and core function. latest api: flutter/flutter#30735