Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test #275

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Add integration test #275

merged 3 commits into from
Jan 6, 2023

Conversation

jpnurmi
Copy link
Contributor

@jpnurmi jpnurmi commented Jan 5, 2023

So far, it's only testing the basics, i.e. calling all the getters. Testing window manipulation is much more challenging because the Flutter integration test driver presumably blocks the main GUI thread.

It's better to test setters in separate test methods to make it possible
to skip them per platform depending on how we are able to make them work
on each platform or not.
@lijy91 lijy91 merged commit cd6dacf into leanflutter:main Jan 6, 2023
@jpnurmi jpnurmi deleted the integration-test branch January 6, 2023 07:31
obiwanzenobi pushed a commit to obiwanzenobi/window_manager that referenced this pull request May 25, 2023
* Add integration test

* CI: run integration test

* Rename integration tests

It's better to test setters in separate test methods to make it possible
to skip them per platform depending on how we are able to make them work
on each platform or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants