Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: value of DWMWA_USE_IMMERSIVE_DARK_MODE changed on newer Windows version #415

Closed
ngxson opened this issue Oct 28, 2023 · 0 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@ngxson
Copy link

ngxson commented Oct 28, 2023

Description:

On windows, the SetBrightness controls the flag DWMWA_USE_IMMERSIVE_DARK_MODE as shown here: https://github.com/leanflutter/window_manager/blob/main/windows/window_manager.cpp#L1002

The value of DWMWA_USE_IMMERSIVE_DARK_MODE is hard coded to 19 in the same file: https://github.com/leanflutter/window_manager/blob/main/windows/window_manager.cpp#L31

However, in the official documentation, this value has been changed to 20: https://learn.microsoft.com/en-us/windows/win32/api/dwmapi/ne-dwmapi-dwmwindowattribute

Impact:

The title bar on windows 11 (light mode) does not display correctly, as seen in #385

Note:

Please also follow this discussion for more information: mintty/mintty#983

cybrox added a commit to Koch-AG/window_manager that referenced this issue Dec 11, 2023
@lijy91 lijy91 self-assigned this May 18, 2024
@lijy91 lijy91 added the bug Something isn't working label May 18, 2024
@lijy91 lijy91 closed this as completed May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants