Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the Windows platform, there is a white space at the bottom of the full screen window #237

Closed
wangchengcheng1992 opened this issue Nov 4, 2022 · 0 comments · Fixed by #359

Comments

@wangchengcheng1992
Copy link

wangchengcheng1992 commented Nov 4, 2022

window_manager_plugin.cpp

std::optional<LRESULT> WindowManagerPlugin::HandleWindowProc(HWND hWnd,
                                                             UINT message,
                                                             WPARAM wParam,
                                                             LPARAM lParam) {
  std::optional<LRESULT> result = std::nullopt;

  if (message == WM_NCCALCSIZE) {
    // This must always be first or else the one of other two ifs will execute
    //  when window is in full screen and we don't want that
    if (wParam && window_manager->IsFullScreen()) {
      NCCALCSIZE_PARAMS* sz = reinterpret_cast<NCCALCSIZE_PARAMS*>(lParam);
      sz->rgrc[0].bottom -= 3;
      return 0;
    }
   
   ...
   ...
}

sz->rgrc[0].bottom -= 3;

Can you tell me why the bottom margin of 3px should be reserved?

Thanks

damywise pushed a commit to damywise/window_manager that referenced this issue Jun 26, 2023
…om fullscreen

- Removes the line that `cuts the app at the bottom by the pixel to prevent jitter when resizing app`
- Remove the line that `cuts the app by 3 pixels at the bottom when full screen`
- Fixes leanflutter#311, leanflutter#266, leanflutter#228, leanflutter#355, leanflutter#237
lijy91 pushed a commit that referenced this issue Jul 1, 2023
…om fullscreen (#359)

- Removes the line that `cuts the app at the bottom by the pixel to prevent jitter when resizing app`
- Remove the line that `cuts the app by 3 pixels at the bottom when full screen`
- Fixes #311, #266, #228, #355, #237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant