#517: Fix emulated touch never changing slide #556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517.
The cause
The
handleClickItem
is called when the mouse click is released on the end of a swipe, which sets theselectedItem
state to the current slide and makes it impossible to change the slide through a swipe on non-touch devices since these devices will always trigger a click event while swiping.Solution
It sets the
cancelClick
state to false ononSwipeForward
andonSwipeBackwards
, which prevents thehandleClickItem
to set theselectedItem
state to the swiped item.