#517: Fix emulated touch never changing slide#556
Merged
leandrowd merged 3 commits intoFeb 12, 2021
Merged
Conversation
|
@leandrowd How often to you accept PR? When could we expect this one to be merged? |
Owner
|
Sorry, I'm a bit time poor ATM. Will try to get to it this week. |
Owner
|
Please test it thoroughly so I only need to press the merge button and publish it... This will make it easier. Let me know once you are confident this is ok to be merged. |
Contributor
Author
|
I believe it can be merged now. |
Owner
|
Published to npm as 3.2.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #517.
The cause
The
handleClickItemis called when the mouse click is released on the end of a swipe, which sets theselectedItemstate to the current slide and makes it impossible to change the slide through a swipe on non-touch devices since these devices will always trigger a click event while swiping.Solution
It sets the
cancelClickstate to false ononSwipeForwardandonSwipeBackwards, which prevents thehandleClickItemto set theselectedItemstate to the swiped item.