Add macOS support #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, can we update the test suite to also run the builds on mac? |
|
Sure. I just updated it. |
|
I merged it but it looks like your builds are failing here: https://github.com/dapetcu21/gh-actions-lua/actions/runs/186309921 |
|
Nevermind, looks like things are good here: https://github.com/leafo/gh-actions-lua/runs/920962561 Thanks for the contribution |
|
Yes, because the tests were referencing the action as |
|
Oh! One more thing: Can you, please, make a release so that I can reference it in my workflows and not rely on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now runs under macOS runners. Ideally, the deployment target shouldn't be hardcoded to 10.15, but it won't break when 11.0 releases.
Fixes #8