Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in HERE variant names #304

Closed
Toutouwai opened this issue Oct 26, 2018 · 4 comments
Closed

Typos in HERE variant names #304

Toutouwai opened this issue Oct 26, 2018 · 4 comments

Comments

@Toutouwai
Copy link

Typos here:

redcuedDay: 'reduced.day',
redcuedNight: 'reduced.night',
@brunob
Copy link
Member

brunob commented Oct 27, 2018

Nice catch, this comes from a8f4039

@jieter should we fix this "silently" or fix this and keep the typos as alias in order to doesn't break use cases already in place from user side ?

@jieter
Copy link
Contributor

jieter commented Oct 27, 2018

Hmm, good question. I suspect it won't break many sites, because they'll will either copy a definition from the preview or use the lib as a list.

Let's keep it simple and just fix the typos.

@brunob brunob closed this as completed in 65bb0b7 Oct 28, 2018
@brunob
Copy link
Member

brunob commented Oct 28, 2018

Done, i think it's time to push a new release.

@brunob
Copy link
Member

brunob commented Oct 28, 2018

@jieter wait a bit, i think we can also fix some thing for cartodb tiles... (PR coming)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants