Skip to content

Commit d1c371b

Browse files
committed
[libc++] Move the check-generated-files job to Github Actions
This allows running these quick checks faster than in our Buildkite pipeline, which has much more latency. This will also avoid blocking the rest of the testing pipeline in case the generated-files checks are failing.
1 parent b3a39a9 commit d1c371b

File tree

2 files changed

+25
-19
lines changed

2 files changed

+25
-19
lines changed
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
name: "Check libc++ generated files"
2+
on:
3+
pull_request:
4+
paths:
5+
- 'libcxx/**'
6+
7+
jobs:
8+
check_generated_files:
9+
runs-on: ubuntu-latest
10+
steps:
11+
- name: Fetch LLVM sources
12+
uses: actions/checkout@v4
13+
with:
14+
fetch-depth: 2
15+
16+
- name: Install clang-format
17+
uses: aminya/setup-cpp@v1
18+
with:
19+
clangformat: 17.0.1
20+
21+
- name: Install Ninja
22+
uses: llvm/actions/install-ninja
23+
24+
- name: Check generated files
25+
run: libcxx/utils/ci/run-buildbot check-generated-output

libcxx/utils/ci/buildkite-pipeline.yml

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -26,31 +26,12 @@ env:
2626
# LLVM POST-BRANCH bump version
2727
# LLVM POST-BRANCH add compiler test for ToT - 1, e.g. "Clang 17"
2828
# LLVM RELEASE bump remove compiler ToT - 3, e.g. "Clang 15"
29-
LLVM_STABLE_VERSION: "17" # Used for tooling, update after the RELEASE.
3029
LLVM_HEAD_VERSION: "18" # Used compiler, update POST-BRANCH.
3130
GCC_STABLE_VERSION: "13"
3231
steps:
3332
#
3433
# Light pre-commit tests for things like forgetting to update generated files.
3534
#
36-
- label: "Generated output"
37-
command: "libcxx/utils/ci/run-buildbot check-generated-output"
38-
artifact_paths:
39-
- "**/generated_output.patch"
40-
- "**/generated_output.status"
41-
env:
42-
CC: "clang-${LLVM_HEAD_VERSION}"
43-
CXX: "clang++-${LLVM_HEAD_VERSION}"
44-
CLANG_FORMAT: "/usr/bin/clang-format-${LLVM_STABLE_VERSION}"
45-
agents:
46-
queue: "libcxx-builders"
47-
os: "linux"
48-
retry:
49-
automatic:
50-
- exit_status: -1 # Agent was lost
51-
limit: 2
52-
timeout_in_minutes: 120
53-
5435
- label: "Documentation"
5536
command: "libcxx/utils/ci/run-buildbot documentation"
5637
artifact_paths:

0 commit comments

Comments
 (0)