Fix build outside source dir #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -281,11 +290,18 @@ if(BUILD_BC_LIBS) | |||
| set(BCLIBS bclibs) | |||
| endif(BUILD_BC_LIBS) | |||
|
|
|||
| if(D_VERSION EQUAL 2) | |||
| if(NOT ROJECT_BINARY_DIR STREQUAL "${PROJECT_SOURCE_DIR}") | |||
| file(COPY ${PROJECT_PARENT_DIR}/${RUNTIME} DESTINATION ${PROJECT_BINARY_DIR}/../) | |||
There was a problem hiding this comment.
yes typo, thanks
| install(FILES ${PROJECT_SOURCE_DIR}/bin/${LDC_EXE}.rebuild.conf DESTINATION ${CONF_INST_DIR}) | ||
| install(FILES ${library} DESTINATION ${CMAKE_INSTALL_LIBDIR}) | ||
|
|
||
| if(NOT "" STREQUAL "") |
There was a problem hiding this comment.
This looks like the result of a search/replace accident…
|
oh yes right i miss remove this code, unused since chroot_install_dir is removed |
| set(CONF_INST_DIR ${SYSCONF_INSTALL_DIR} CACHE PATH "Set ldc.conf directory for installation") | ||
| set(LIBRARY_OUTPUT_PATH ${PROJECT_BINARY_DIR}/lib${LIB_SUFFIX} CACHE PATH "output dir for built libraries") | ||
| set(INCLUDE_INSTALL_DIR ${CMAKE_INSTALL_PREFIX}/include/d CACHE PATH "Directory where will be put header files") | ||
| set(BUILD_SHARED_LIBS ON CACHE BOOL "Build as shared library or as static library") |
There was a problem hiding this comment.
Why is it enabled by default? It probably works only on linux.
|
Since this pull request became quite a mess over time, I merged a slightly cleaned up version (less whitespace changes, removed the unused |
Closed
redstar
added a commit
that referenced
this pull request
Sep 27, 2014
timotheecour
pushed a commit
to timotheecour/ldc
that referenced
this pull request
Dec 13, 2017
…ter types returned by semantic(). Sometimes types aren't merged and their deco are copied manually, do the same for equivDeco so function overriding works properly.
timotheecour
pushed a commit
to timotheecour/ldc
that referenced
this pull request
Dec 13, 2017
Unlike Clang, LDC flattens anon structs into the parent's LLVM struct type:
%withanonstruct_d = type { i32, float, i8, [3 x i8] } ; LDC
%struct.withanonstruct_cpp = type { i32, %struct.anon } ; Clang
%struct.anon = type { float, i8 }
Same goes for base classes and anonymous unions, so Calypso shouldn't access fields through LDC's flat varGEPIndices.
This didn't cause issues with base classes because the derived class pointer is always bitcast to the base one, but it did break if buildGEPIndices was querying the LLVM field number for an injected field.
Letting Clang handle the GEP construction is a more robust approach, and this fixes the segfault during codegen while compiling wilsonk's FastFlow demo (ldc-developers#12).
timotheecour
pushed a commit
to timotheecour/ldc
that referenced
this pull request
Dec 13, 2017
Default ctors and dtors of records that are implicitly called if a field is one such record may not appear anywhere in its parent AST node. Fixes the remaining linking error from ldc-developers#12.
timotheecour
pushed a commit
to timotheecour/ldc
that referenced
this pull request
Dec 13, 2017
Clang was already trying to emit a global ctor/dtor for global variables, but assumed wrong that @llvm.global_ctors didn't exist. This fixes the segfault of the FastFlow example by wilsonk (ldc-developers#12).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build outside source dir